Update from update/networkservicemesh/sdk #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k@master networkservicemesh/sdk#460 networkservicemesh/sdk PR link: networkservicemesh/sdk#460 networkservicemesh/sdk commit message: commit 5b64906a352b8b04a60e5eaf386a4d59a4bbe58d Author: Denis Tingaikin <49399980+denis-tingajkin@users.noreply.github.com> Date: Wed Sep 16 15:33:09 2020 +0700 Cover nsmgr remote use-case via grpc unit tests (#460) * Add nsmgr local/remote grpc tests Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> * fix linter issues Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> * extract chaintest Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> * add possible to pass custom context Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com> * apply review comments Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com> * self code review Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit bb00a36