Add workloadapi options for cmd-registry-memory #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com>
Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com>
edwarnicke
reviewed
Aug 16, 2020
| source, err := workloadapi.NewX509Source(ctx) | ||
| source, err := workloadapi.NewX509Source(ctx, | ||
| workloadapi.WithClientOptions(workloadapi.WithLogger(log.Entry(ctx))), | ||
| workloadapi.WithDefaultX509SVIDPicker(func(svids []*x509svid.SVID) *x509svid.SVID { |
There was a problem hiding this comment.
So I'm not clear why we are using the SVID Picker here...
There was a problem hiding this comment.
Actually the deployment can fetch few svids. By default workloadapi.NewX509Source just picks first.
So I think we should pick svid for registry if for that has been added spire entry.
There was a problem hiding this comment.
Hmm... I'm inclined to not worry about it right now... in practice at least in K8s, I believe its only returning one SVID, and this forces an SVID schema on users they may not want.
There was a problem hiding this comment.
in practice at least in K8s, I believe its only returning one SVID
I guess it is related to user spire setup...
nsmbot
pushed a commit
that referenced
this pull request
Dec 29, 2020
This PR syncs files with https://github.com/networkservicemesh/cmd-template Revision: https://github.com/networkservicemesh/cmd-template/commits/5e735856d8be1fb56c377c31bb57f8094d8f38f6 commit 5e735856d8be1fb56c377c31bb57f8094d8f38f6 Author: Denis Tingaikin <49399980+denis-tingajkin@users.noreply.github.com> Date: Tue Dec 29 13:49:50 2020 +0700 update golangci linter (#56) Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: denis-tingajkin denis.tingajkin@xored.com
Motivation
Added svid picker
Added spire logging