Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Web admissions controller to deployments-K8s #481

Closed
edwarnicke opened this issue Mar 8, 2021 · 0 comments · Fixed by #730
Closed

Apply Web admissions controller to deployments-K8s #481

edwarnicke opened this issue Mar 8, 2021 · 0 comments · Fixed by #730
Assignees

Comments

@edwarnicke
Copy link
Member

Currently in deployment-k8s we are manually putting the nsc containers into the Pods... we should switch to doing that with a web admissions controller once:

networkservicemesh/cmd-admission-webhook-k8s#1

Is complete.

@denis-tingaikin denis-tingaikin self-assigned this Apr 2, 2021
nsmbot pushed a commit that referenced this issue Jul 5, 2022
…d-nsc-init@main

PR link: networkservicemesh/cmd-nsc-init#481

Commit: 3693d7e
Author: Denis Tingaikin
Date: 2022-07-05 11:59:52 +0300
Message:
  - Merge pull request #481 from NikitaSkrynnik/add-metadata
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit that referenced this issue May 29, 2024
…d-nse-vlan-vpp@main

PR link: networkservicemesh/cmd-nse-vlan-vpp#481

Commit: c1e108e
Author: Network Service Mesh Bot
Date: 2024-05-29 06:05:56 -0500
Message:
  - Update from update/networkservicemesh/sdk-vpp (#481)
* Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main
PR link: networkservicemesh/sdk-vpp#833
Commit: 345d2ce
Author: Network Service Mesh Bot
Date: 2024-05-29 05:59:24 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#833)
PR link: networkservicemesh/sdk-kernel#665
Commit: 06cfa69
Author: Network Service Mesh Bot
Date: 2024-05-29 05:55:56 -0500
Message:
        - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#665)
PR link: networkservicemesh/sdk#1636
Commit: c01f9e1
Author: Nikita Skrynnik
Date: 2024-05-29 21:53:30 +1100
Message:
                - Add peer cleanup on Requests and Closes from begin (#1636)
* Add peer cleanup on Requests and Closes from begin
* fix go linter issues
* fix race condition + fix all go linter issues
---------
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
* Automatically resolving conflicts in go.mod and updating dependency versions to the latest
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
---------
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot added a commit that referenced this issue May 29, 2024
…d-nse-vlan-vpp@main (#12057)

PR link: networkservicemesh/cmd-nse-vlan-vpp#481

Commit: c1e108e
Author: Network Service Mesh Bot
Date: 2024-05-29 06:05:56 -0500
Message:
  - Update from update/networkservicemesh/sdk-vpp (#481)
* Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main
PR link: networkservicemesh/sdk-vpp#833
Commit: 345d2ce
Author: Network Service Mesh Bot
Date: 2024-05-29 05:59:24 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#833)
PR link: networkservicemesh/sdk-kernel#665
Commit: 06cfa69
Author: Network Service Mesh Bot
Date: 2024-05-29 05:55:56 -0500
Message:
        - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#665)
PR link: networkservicemesh/sdk#1636
Commit: c01f9e1
Author: Nikita Skrynnik
Date: 2024-05-29 21:53:30 +1100
Message:
                - Add peer cleanup on Requests and Closes from begin (#1636)
* Add peer cleanup on Requests and Closes from begin
* fix go linter issues
* fix race condition + fix all go linter issues
---------

* Automatically resolving conflicts in go.mod and updating dependency versions to the latest

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants