Update from update/networkservicemesh/sdk #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k@main networkservicemesh/sdk# networkservicemesh/sdk PR link: https://github.com/networkservicemesh/sdk/pull/ networkservicemesh/sdk commit message: commit 2f267b7a5b1bcf896a579564e91c6a33ed80c37b Author: Uzlov Danil <36223296+d-uzlov@users.noreply.github.com> Date: Tue May 4 16:23:47 2021 +0700 Fix Test_WatchFile instability (#886) * enable testing for WatchFile Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * add checks into watchFile test Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * add proper checks for PathError Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * use unique path for every test attempt Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * clean error checking code Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * exclude ubuntu and macos from testing Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * retry mkdir on failure Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * reenable ubuntu and macos testing Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * add extra info for macos debuging Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * print each event Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * mitigate macos inconsistency Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * test Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * test Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * add more debug logs Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * clean code Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * remove sleep Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * revert from context timeout to timeout per event Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * enable all tests Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * clean code Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * extract constant for macos-specific behaviour handling Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * refactor Test_WatchFile Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * format Test_WatchFile Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * use more appropriate test checking functions Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * remove log helper function Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * expect separate create and write events Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * fix linter warning Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * use context with timeout instead of manual timeouts Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * use testing.TempDir instead of system temp dir Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * clean code Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * remove unnecessary stuff around testing.TempDir Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit 96c8481 Author: NSMBot nsmbot@networkservicmesh.io Date: Tue May 4 09:24:17 2021 +0000 Update go.mod and go.sum to latest version from networkservicemesh/sdk@main networkservicemesh/sdk# networkservicemesh/sdk PR link: https://github.com/networkservicemesh/sdk/pull/ networkservicemesh/sdk commit message: commit 2f267b7a5b1bcf896a579564e91c6a33ed80c37b Author: Uzlov Danil 36223296+d-uzlov@users.noreply.github.com Date: Tue May 4 16:23:47 2021 +0700 Fix Test_WatchFile instability (#886) README.md go.mod go.sum pkg enable testing for WatchFile Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg add checks into watchFile test Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg add proper checks for PathError Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg use unique path for every test attempt Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg clean error checking code Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg exclude ubuntu and macos from testing Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg retry mkdir on failure Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg reenable ubuntu and macos testing Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg add extra info for macos debuging Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg print each event Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg mitigate macos inconsistency Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg test Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg test Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg add more debug logs Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg clean code Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg remove sleep Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg revert from context timeout to timeout per event Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg enable all tests Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg clean code Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg extract constant for macos-specific behaviour handling Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg refactor Test_WatchFile Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg format Test_WatchFile Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg use more appropriate test checking functions Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg remove log helper function Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg expect separate create and write events Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg fix linter warning Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg use context with timeout instead of manual timeouts Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg use testing.TempDir instead of system temp dir Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg clean code Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg remove unnecessary stuff around testing.TempDir Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru Signed-off-by: NSMBot nsmbot@networkservicmesh.io