Update from update/networkservicemesh/sdk #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k@main networkservicemesh/sdk# networkservicemesh/sdk PR link: https://github.com/networkservicemesh/sdk/pull/ networkservicemesh/sdk commit message: commit 93d252947219d952fd428e98e86e63ea17550579 Author: Uzlov Danil <36223296+d-uzlov@users.noreply.github.com> Date: Tue May 11 21:22:51 2021 +0700 Add onidle chain element (#908) * add endpointtimeout chain element Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * fix TestEndpointTimeout_ContextCancel instability Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * make endpointTimeoutServer track connections, fix concurrency issues Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * rename package endpointtimeout to idlenotifier Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * fix formatting Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * add HoldingActiveRequest test, clean code Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * fix race in *endpointTimeoutServer) Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * add TestIdleNotifier_FailedRequest Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * fix missing error check Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * make idlenotifier.notify action argument mandatory Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * rename package idlenotifier to onidle Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * fix TestIdleNotifier_ContextCancel instability Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * clean code Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * fix race in onIdleServer Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * fix timer leak Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * use require.Eventually + goleak.Find instead of time.Sleep in TestIdleNotifier_ContextCancel Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * remove excessive removeConnection call Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * use simple map instead of sync.Map in onIdleServer Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * adjuct comments Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * refactor timer handling Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * add TestIdleNotifier_RequestAfterExpire test Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * remove unneeded check from TestIdleNotifier_ContextCancel Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * fix non-american "cancelled" spelling error Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * add extra check for context error Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * increase check timeout from 50ms to 100ms Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * extract notify callback to be not under the mutex Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * apply suggestions from code review Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit 38ca7e4 Author: NSMBot nsmbot@networkservicmesh.io Date: Tue May 11 14:23:30 2021 +0000 Update go.mod and go.sum to latest version from networkservicemesh/sdk@main networkservicemesh/sdk# networkservicemesh/sdk PR link: https://github.com/networkservicemesh/sdk/pull/ networkservicemesh/sdk commit message: commit 93d252947219d952fd428e98e86e63ea17550579 Author: Uzlov Danil 36223296+d-uzlov@users.noreply.github.com Date: Tue May 11 21:22:51 2021 +0700 Add onidle chain element (#908) README.md go.mod go.sum pkg add endpointtimeout chain element Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg fix TestEndpointTimeout_ContextCancel instability Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg make endpointTimeoutServer track connections, fix concurrency issues Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg rename package endpointtimeout to idlenotifier Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg fix formatting Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg add HoldingActiveRequest test, clean code Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg fix race in *endpointTimeoutServer) Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg add TestIdleNotifier_FailedRequest Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg fix missing error check Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg make idlenotifier.notify action argument mandatory Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg rename package idlenotifier to onidle Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg fix TestIdleNotifier_ContextCancel instability Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg clean code Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg fix race in onIdleServer Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg fix timer leak Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg use require.Eventually + goleak.Find instead of time.Sleep in TestIdleNotifier_ContextCancel Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg remove excessive removeConnection call Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg use simple map instead of sync.Map in onIdleServer Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg adjuct comments Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg refactor timer handling Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg add TestIdleNotifier_RequestAfterExpire test Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg remove unneeded check from TestIdleNotifier_ContextCancel Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg fix non-american "cancelled" spelling error Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg add extra check for context error Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg increase check timeout from 50ms to 100ms Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg extract notify callback to be not under the mutex Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru README.md go.mod go.sum pkg apply suggestions from code review Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru Signed-off-by: NSMBot nsmbot@networkservicmesh.io