Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missed serialize chain elements #150

Conversation

denis-tingaikin
Copy link
Member

@denis-tingaikin denis-tingaikin commented May 11, 2021

Signed-off-by: denis-tingajkin denis.tingajkin@xored.com

Motivation

When networkservicemesh/sdk@9b80b55 had landed no one is not updated sdk-k8s registry.

Now testing could fail networkservicemesh/integration-k8s-kind#215 by missed serialize chain element by error:

2021-05-11T15:04:03.219435588Z panic: runtime error: invalid memory address or nil pointer dereference
2021-05-11T15:04:03.219447688Z [signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0x903b42]
2021-05-11T15:04:03.219451088Z 
2021-05-11T15:04:03.219455688Z goroutine 167 [running]:
2021-05-11T15:04:03.219459788Z github.com/networkservicemesh/sdk/pkg/tools/serializectx.(*Executor).AsyncExec(0x0, 0xc0006d56b0, 0x440516)
2021-05-11T15:04:03.219463688Z 	/go/pkg/mod/github.com/networkservicemesh/sdk@v0.0.0-20210511142251-93d252947219/pkg/tools/serializectx/executor.go:27 +0x22
2021-05-11T15:04:03.219467188Z github.com/networkservicemesh/sdk/pkg/tools/expire.(*Manager).New.func1()
2021-05-11T15:04:03.219470588Z 	/go/pkg/mod/github.com/networkservicemesh/sdk@v0.0.0-20210511142251-93d252947219/pkg/tools/expire/manager.go:64 +0xdb
2021-05-11T15:04:03.219473989Z created by time.goFunc
2021-05-11T15:04:03.219477489Z 	/usr/local/go/src/time/sleep.go:180 +0x45

Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com>
@edwarnicke edwarnicke merged commit 683110c into networkservicemesh:main May 11, 2021
nsmbot pushed a commit that referenced this pull request Nov 8, 2022
…k@main

PR link: networkservicemesh/sdk#1380

Commit: e51c7ad
Author: Network Service Mesh Bot
Date: 2022-11-08 05:45:00 -0600
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/api@main (#1380)
PR link: networkservicemesh/api#150

Commit: f71f283
Author: Nikita Skrynnik
Date: 2022-11-08 17:52:51 +0700
Message:
    - add automerge reusable workflow (#150)
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit that referenced this pull request Nov 9, 2022
…k@main

PR link: networkservicemesh/sdk#1380

Commit: e51c7ad
Author: Network Service Mesh Bot
Date: 2022-11-08 05:45:00 -0600
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/api@main (#1380)
PR link: networkservicemesh/api#150

Commit: f71f283
Author: Nikita Skrynnik
Date: 2022-11-08 17:52:51 +0700
Message:
    - add automerge reusable workflow (#150)
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@ThetaDR ThetaDR mentioned this pull request Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants