Removed env provided namespace #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mixaster995
changed the title
Mixaster995
force-pushed
the
enhancement/handle-all-namespaces
branch
from
168b5d6
to
a8890a6
Compare
Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>
Mixaster995
force-pushed
the
enhancement/handle-all-namespaces
branch
from
a8890a6
to
4329b82
Compare
| if err == nil { | ||
| exist.Spec = *(*v1.NetworkServiceSpec)(request) | ||
| apiResp, err = n.client.NetworkservicemeshV1().NetworkServices(n.ns).Update(ctx, exist, metav1.UpdateOptions{}) |
There was a problem hiding this comment.
Finally I think we should keep n.ns for Create and Update.
Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>
Mixaster995
force-pushed
the
enhancement/handle-all-namespaces
branch
from
949af1a
to
bda9091
Compare
Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>
|
@denis-tingaikin added unit tests |
denis-tingaikin
approved these changes
Oct 12, 2021
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-sriov
that referenced
this pull request
Oct 12, 2021
…k-k8s@main PR link: networkservicemesh/sdk-k8s#253 Commit: bb5bbe1 Author: Denis Tingaikin Date: 2021-10-12 09:36:02 +0300 Message: - Merge pull request #253 from Mixaster995/enhancement/handle-all-namespaces Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-supplier-k8s
that referenced
this pull request
Oct 12, 2021
…k-k8s@main PR link: networkservicemesh/sdk-k8s#253 Commit: bb5bbe1 Author: Denis Tingaikin Date: 2021-10-12 09:36:02 +0300 Message: - Merge pull request #253 from Mixaster995/enhancement/handle-all-namespaces Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-k8s
that referenced
this pull request
Oct 12, 2021
…k-k8s@main PR link: networkservicemesh/sdk-k8s#253 Commit: bb5bbe1 Author: Denis Tingaikin Date: 2021-10-12 09:36:02 +0300 Message: - Merge pull request #253 from Mixaster995/enhancement/handle-all-namespaces Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mikhail Avramenko avramenkomihail15@gmail.com
Issue
#252