[qfix] Close VPP dump clients #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Bolodya1997
requested review from
edwarnicke,
glazychev-art and
denis-tingaikin
glazychev-art
approved these changes
Sep 24, 2021
denis-tingaikin
approved these changes
Sep 24, 2021
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Bolodya1997
force-pushed
the
qfix/leaks
branch
from
d15d504 to
7eff2f3
Compare
Done. |
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-firewall-vpp
that referenced
this pull request
Sep 24, 2021
…k-vpp@main PR link: networkservicemesh/sdk-vpp#389 Commit: 6a03cfb Author: Vladimir Popov Date: 2021-09-24 17:55:26 +0700 Message: - [qfix] Close VPP dump clients (#389) * Close VPP dump clients Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Increase golangci timeout Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-vpp
that referenced
this pull request
Sep 24, 2021
…k-vpp@main PR link: networkservicemesh/sdk-vpp#389 Commit: 6a03cfb Author: Vladimir Popov Date: 2021-09-24 17:55:26 +0700 Message: - [qfix] Close VPP dump clients (#389) * Close VPP dump clients Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Increase golangci timeout Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-icmp-responder-vpp
that referenced
this pull request
Sep 24, 2021
…k-vpp@main PR link: networkservicemesh/sdk-vpp#389 Commit: 6a03cfb Author: Vladimir Popov Date: 2021-09-24 17:55:26 +0700 Message: - [qfix] Close VPP dump clients (#389) * Close VPP dump clients Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Increase golangci timeout Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-vpp
that referenced
this pull request
Sep 24, 2021
…k-vpp@main PR link: networkservicemesh/sdk-vpp#389 Commit: 6a03cfb Author: Vladimir Popov Date: 2021-09-24 17:55:26 +0700 Message: - [qfix] Close VPP dump clients (#389) * Close VPP dump clients Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Increase golangci timeout Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Sep 24, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes VPP dump clients to prevent memory leaks.
Related issue
networkservicemesh/deployments-k8s#2381