[qfix] Check if error is nil in proxy listener #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Bolodya1997
requested review from
edwarnicke,
denis-tingaikin,
glazychev-art and
Mixaster995
Mixaster995
approved these changes
Oct 13, 2021
glazychev-art
approved these changes
Oct 13, 2021
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-vpp
that referenced
this pull request
Oct 13, 2021
…k-vpp@main PR link: networkservicemesh/sdk-vpp#407 Commit: a57956d Author: Vladimir Popov Date: 2021-10-13 13:06:05 +0700 Message: - Check if error is nil in proxy listener (#407) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-icmp-responder-vpp
that referenced
this pull request
Oct 13, 2021
…k-vpp@main PR link: networkservicemesh/sdk-vpp#407 Commit: a57956d Author: Vladimir Popov Date: 2021-10-13 13:06:05 +0700 Message: - Check if error is nil in proxy listener (#407) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-vpp
that referenced
this pull request
Oct 13, 2021
…k-vpp@main PR link: networkservicemesh/sdk-vpp#407 Commit: a57956d Author: Vladimir Popov Date: 2021-10-13 13:06:05 +0700 Message: - Check if error is nil in proxy listener (#407) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-firewall-vpp
that referenced
this pull request
Oct 13, 2021
…k-vpp@main PR link: networkservicemesh/sdk-vpp#407 Commit: a57956d Author: Vladimir Popov Date: 2021-10-13 13:06:05 +0700 Message: - Check if error is nil in proxy listener (#407) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Oct 13, 2021
Mixaster995
added a commit
to Mixaster995/sdk-vpp
that referenced
this pull request
Oct 13, 2021
…)" This reverts commit a57956d.
Mixaster995
added a commit
to Mixaster995/sdk-vpp
that referenced
this pull request
Oct 13, 2021
…)" This reverts commit a57956d. Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>
nsmbot
pushed a commit
that referenced
this pull request
Jan 24, 2022
…k-kernel@main PR link: networkservicemesh/sdk-kernel#407 Commit: 2292537 Author: Denis Tingaikin Date: 2022-01-24 19:19:23 +0300 Message: - Merge pull request #407 from glazychev-art/iprule Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Continues #403 and fixes introduced error.
Motivation
If
erris nilokwill also befalse.How Has This Been Tested?
Types of changes