MTU fix for cmd-forwarder-vpp#557 #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ed Warnicke <hagbard@gmail.com>
edwarnicke
commented
Apr 11, 2022
| } | ||
|
|
||
| func setVPPL3MTU(ctx context.Context, conn *networkservice.Connection, vppConn api.Connection, isClient bool) error { | ||
| func setVPPMTU(ctx context.Context, conn *networkservice.Connection, vppConn api.Connection, isClient bool) error { |
There was a problem hiding this comment.
Abandon setting the LinkMTU entirely as it no longer works remotely as expected.
This appears to be due to changes in VPP driven by changes in DPDK on MTU handling no longer following 802.3 on MTU handling.
edwarnicke
commented
Apr 11, 2022
| // inner ethernet header - 14 bytes | ||
| // optional overhead for 802.1q vlan tags - 4 bytes | ||
| // total - 74 bytes | ||
| return 74 |
There was a problem hiding this comment.
Correctly handle overhead for VXLAN (previously we'd only been handling for IPv4 with no available overhead for 802.1q tags).
edwarnicke
commented
Apr 11, 2022
| // 8-byte nonce | ||
| // 16-byte authentication tag | ||
| // 80 bytes total | ||
| return 80 |
There was a problem hiding this comment.
Correctly handle overhead for IPv4 case for wireguard.
This was referenced Apr 11, 2022
denis-tingaikin
approved these changes
Apr 11, 2022
There was a problem hiding this comment.
All changes are looking good.
@glazychev-art I think it'd be interested to look at these changes for you.
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-vpp
that referenced
this pull request
Apr 11, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#554 Commit: dc652f0 Author: Ed Warnicke Date: 2022-04-11 13:50:40 -0500 Message: - MTU fix for cmd-forwarder-vpp#557 (#554) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-vpp
that referenced
this pull request
Apr 11, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#554 Commit: dc652f0 Author: Ed Warnicke Date: 2022-04-11 13:50:40 -0500 Message: - MTU fix for cmd-forwarder-vpp#557 (#554) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-firewall-vpp
that referenced
this pull request
Apr 11, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#554 Commit: dc652f0 Author: Ed Warnicke Date: 2022-04-11 13:50:40 -0500 Message: - MTU fix for cmd-forwarder-vpp#557 (#554) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-icmp-responder-vpp
that referenced
this pull request
Apr 11, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#554 Commit: dc652f0 Author: Ed Warnicke Date: 2022-04-11 13:50:40 -0500 Message: - MTU fix for cmd-forwarder-vpp#557 (#554) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vl3-vpp
that referenced
this pull request
Apr 11, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#554 Commit: dc652f0 Author: Ed Warnicke Date: 2022-04-11 13:50:40 -0500 Message: - MTU fix for cmd-forwarder-vpp#557 (#554) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vlan-vpp
that referenced
this pull request
Apr 11, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#554 Commit: dc652f0 Author: Ed Warnicke Date: 2022-04-11 13:50:40 -0500 Message: - MTU fix for cmd-forwarder-vpp#557 (#554) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Apr 11, 2022
Merged
ljkiraly
added a commit
to Nordix/nsm-sdk-vpp
that referenced
this pull request
Apr 12, 2022
Issue: networkservicemesh/cmd-forwarder#557 Related PR: networkservicemesh#554 The L3 MTU is set based on link L2 mtu and should not modified. Signed-off-by: Laszlo Kiraly <laszlo.kiraly@est.tech>
edwarnicke
pushed a commit
that referenced
this pull request
Apr 12, 2022
Issue: networkservicemesh/cmd-forwarder#557 Related PR: #554 The L3 MTU is set based on link L2 mtu and should not modified. Signed-off-by: Laszlo Kiraly <laszlo.kiraly@est.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ed Warnicke hagbard@gmail.com