Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use goleak in each test to avoid goroutines leaks #361

Closed
denis-tingaikin opened this issue Jul 2, 2020 · 0 comments
Closed

Use goleak in each test to avoid goroutines leaks #361

denis-tingaikin opened this issue Jul 2, 2020 · 0 comments
Labels
good first issue Good for newcomers

Comments

@denis-tingaikin
Copy link
Member

Description

We've found one interesting problem with goleak uber-go/goleak#48, in short it can detect leaks from other tests.

Potential solution

We can avoid this problem if we'll use goleak tool in each test.
@denis-tingaikin denis-tingaikin added the good first issue Good for newcomers label Jul 2, 2020
@denis-tingaikin denis-tingaikin mentioned this issue Jul 20, 2020
Merged
@denis-tingaikin denis-tingaikin changed the title Use goleak in each test to avoid wrong leaks detection Use goleak in each test to avoid goroutines leaks Jul 23, 2020
@haiodo haiodo closed this as completed Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@haiodo @denis-tingaikin