Update go-leak tool to avoid problems with false negative results #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denis-tingaikin
force-pushed
the
fix_goleak_using
branch
2 times, most recently
from
50ad1c3
to
599f5dd
Compare
Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com>
denis-tingaikin
force-pushed
the
fix_goleak_using
branch
from
599f5dd
to
fcb3b2a
Compare
haiodo
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Denis Tingajkin denis.tingajkin@xored.com
Motivation
We've provided PR for uber-go/go-leak tool uber-go/goleak#49 to avoid false-positive results in our tests(look at issue #361)
Now we can use go-leak with an option that ignores spawned goroutines from previous tests. It is not a solution of 361, but it makes our tests result purer.