-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set default kernel interface name #1014
Merged
edwarnicke
merged 2 commits into
networkservicemesh:main
from
glazychev-art:kernel_name
Jul 13, 2021
Merged
Set default kernel interface name #1014
edwarnicke
merged 2 commits into
networkservicemesh:main
from
glazychev-art:kernel_name
Jul 13, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glazychev-art
force-pushed
the
kernel_name
branch
from
July 12, 2021 10:22
342603e
to
ad33552
Compare
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
glazychev-art
force-pushed
the
kernel_name
branch
from
July 12, 2021 11:30
ad33552
to
2a95b16
Compare
edwarnicke
reviewed
Jul 12, 2021
Bolodya1997
reviewed
Jul 13, 2021
Mixaster995
approved these changes
Jul 13, 2021
glazychev-art
force-pushed
the
kernel_name
branch
2 times, most recently
from
July 13, 2021 12:03
13d42a9
to
7cdbfcf
Compare
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
glazychev-art
force-pushed
the
kernel_name
branch
from
July 13, 2021 12:07
7cdbfcf
to
f777bbc
Compare
This was referenced Jul 13, 2021
) | ||
|
||
// GetNameFromConnection - returns a name computed from networkservice.Connection 'conn' | ||
func GetNameFromConnection(conn *networkservice.Connection) string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@glazychev-art Why is this public?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
networkservicemesh/sdk-vpp#254
Signed-off-by: Artem Glazychev artem.glazychev@xored.com
Description
Set default name for kernel interface
Issue link
How Has This Been Tested?
Types of changes