Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default kernel interface name #1014

Merged
merged 2 commits into from
Jul 13, 2021

Conversation

glazychev-art
Copy link
Contributor

@glazychev-art glazychev-art commented Jul 12, 2021

networkservicemesh/sdk-vpp#254
Signed-off-by: Artem Glazychev artem.glazychev@xored.com

Description

Set default name for kernel interface

Issue link

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
@glazychev-art glazychev-art marked this pull request as ready for review July 13, 2021 04:22
@glazychev-art glazychev-art force-pushed the kernel_name branch 2 times, most recently from 13d42a9 to 7cdbfcf Compare July 13, 2021 12:03
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
)

// GetNameFromConnection - returns a name computed from networkservice.Connection 'conn'
func GetNameFromConnection(conn *networkservice.Connection) string {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glazychev-art Why is this public?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants