[sdk#1039] Reorder client chain elements #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mixaster995
approved these changes
Jul 26, 2021
d-uzlov
reviewed
Jul 26, 2021
Bolodya1997
force-pushed
the
sdk#1039/heal-client
branch
2 times, most recently
from
138c7fd
to
e32de6c
Compare
d-uzlov
approved these changes
Jul 26, 2021
glazychev-art
approved these changes
Jul 26, 2021
There was a problem hiding this comment.
Looks good.
@Bolodya1997 Could you please move refactoring regarding to count server to separate PR.
Thanks.
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Bolodya1997
force-pushed
the
sdk#1039/heal-client
branch
from
e32de6c
to
fa4a19e
Compare
denis-tingaikin
approved these changes
Aug 12, 2021
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Aug 12, 2021
…k@main PR link: networkservicemesh/sdk#1040 Commit: eeed158 Author: Vladimir Popov Date: 2021-08-12 14:04:52 +0700 Message: - Fix client chain elements order (#1040) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-icmp-responder
that referenced
this pull request
Aug 12, 2021
…k@main PR link: networkservicemesh/sdk#1040 Commit: eeed158 Author: Vladimir Popov Date: 2021-08-12 14:04:52 +0700 Message: - Fix client chain elements order (#1040) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Aug 12, 2021
…k@main PR link: networkservicemesh/sdk#1040 Commit: eeed158 Author: Vladimir Popov Date: 2021-08-12 14:04:52 +0700 Message: - Fix client chain elements order (#1040) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Aug 12, 2021
…k@main PR link: networkservicemesh/sdk#1040 Commit: eeed158 Author: Vladimir Popov Date: 2021-08-12 14:04:52 +0700 Message: - Fix client chain elements order (#1040) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Aug 12, 2021
…k@main PR link: networkservicemesh/sdk#1040 Commit: eeed158 Author: Vladimir Popov Date: 2021-08-12 14:04:52 +0700 Message: - Fix client chain elements order (#1040) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Aug 12, 2021
…k@main PR link: networkservicemesh/sdk#1040 Commit: eeed158 Author: Vladimir Popov Date: 2021-08-12 14:04:52 +0700 Message: - Fix client chain elements order (#1040) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Aug 12, 2021
…k@main PR link: networkservicemesh/sdk#1040 Commit: eeed158 Author: Vladimir Popov Date: 2021-08-12 14:04:52 +0700 Message: - Fix client chain elements order (#1040) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Aug 12, 2021
…k@main PR link: networkservicemesh/sdk#1040 Commit: eeed158 Author: Vladimir Popov Date: 2021-08-12 14:04:52 +0700 Message: - Fix client chain elements order (#1040) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Aug 12, 2021
…k@main PR link: networkservicemesh/sdk#1040 Commit: eeed158 Author: Vladimir Popov Date: 2021-08-12 14:04:52 +0700 Message: - Fix client chain elements order (#1040) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Aug 12, 2021
This was referenced Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Puts
healclient after all other chain elements, right beforenetworkservice.NewNetworkServiceClient(cc)in client, client factory chains.Depends on #1056.
Issue link
Closes #1039.
How Has This Been Tested?
Types of changes