Add healing feature #1113
Merged
Add healing feature #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glazychev-art
force-pushed
the
reselect_heal
branch
28 times, most recently
from
3d72a00
to
9c2180e
Compare
glazychev-art
force-pushed
the
reselect_heal
branch
2 times, most recently
from
2415e07
to
1a7a430
Compare
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
glazychev-art
force-pushed
the
reselect_heal
branch
2 times, most recently
from
69652b3
to
47f40c6
Compare
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
glazychev-art
force-pushed
the
reselect_heal
branch
from
47f40c6
to
16a15e5
Compare
|
We can use it. The point was to keep heal tests separate. PR was updated |
|
@edwarnicke with 16a15e5 we do not need to change grpcfd. Is 16a15e5 look good for you? |
|
LGTM I'm going to hold off on merging till integration-k8s-kind is passing from the P2MP work. |
denis-tingaikin
approved these changes
Nov 11, 2021
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Nov 11, 2021
…k@main PR link: networkservicemesh/sdk#1113 Commit: 0f652be Author: Artem Glazychev Date: 2021-11-11 19:50:13 +0700 Message: - Add healing feature (#1113) * Add begin.WithReselect option Signed-off-by: Ed Warnicke <hagbard@gmail.com> * begin: Merge new outside Requests with heal/refresh information Signed-off-by: Ed Warnicke <hagbard@gmail.com> * Add trimpath chain elements Signed-off-by: Ed Warnicke <hagbard@gmail.com> * [qfix] panic protection in dialer chain element Signed-off-by: Ed Warnicke <hagbard@gmail.com> * Very very rough first pass at heal. Signed-off-by: Ed Warnicke <hagbard@gmail.com> * Not quite working restoration of the nsmgr heal tests TestNSMGR_HealForwarder is still failing. It is probably failing because the interpose chain element does not reselect Forwarders if one does not become available. Signed-off-by: Ed Warnicke <hagbard@gmail.com> * heal: fix TestNSMGR_HealForwarder and remove grpc.WaitTillReady() and grpc.WithBlock() from sandbox.DialOptions() Signed-off-by: Ed Warnicke <hagbard@gmail.com> * Fixes failing tests Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Add healClient option Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Nov 11, 2021
…k@main PR link: networkservicemesh/sdk#1113 Commit: 0f652be Author: Artem Glazychev Date: 2021-11-11 19:50:13 +0700 Message: - Add healing feature (#1113) * Add begin.WithReselect option Signed-off-by: Ed Warnicke <hagbard@gmail.com> * begin: Merge new outside Requests with heal/refresh information Signed-off-by: Ed Warnicke <hagbard@gmail.com> * Add trimpath chain elements Signed-off-by: Ed Warnicke <hagbard@gmail.com> * [qfix] panic protection in dialer chain element Signed-off-by: Ed Warnicke <hagbard@gmail.com> * Very very rough first pass at heal. Signed-off-by: Ed Warnicke <hagbard@gmail.com> * Not quite working restoration of the nsmgr heal tests TestNSMGR_HealForwarder is still failing. It is probably failing because the interpose chain element does not reselect Forwarders if one does not become available. Signed-off-by: Ed Warnicke <hagbard@gmail.com> * heal: fix TestNSMGR_HealForwarder and remove grpc.WaitTillReady() and grpc.WithBlock() from sandbox.DialOptions() Signed-off-by: Ed Warnicke <hagbard@gmail.com> * Fixes failing tests Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Add healClient option Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Nov 11, 2021
…k@main PR link: networkservicemesh/sdk#1113 Commit: 0f652be Author: Artem Glazychev Date: 2021-11-11 19:50:13 +0700 Message: - Add healing feature (#1113) * Add begin.WithReselect option Signed-off-by: Ed Warnicke <hagbard@gmail.com> * begin: Merge new outside Requests with heal/refresh information Signed-off-by: Ed Warnicke <hagbard@gmail.com> * Add trimpath chain elements Signed-off-by: Ed Warnicke <hagbard@gmail.com> * [qfix] panic protection in dialer chain element Signed-off-by: Ed Warnicke <hagbard@gmail.com> * Very very rough first pass at heal. Signed-off-by: Ed Warnicke <hagbard@gmail.com> * Not quite working restoration of the nsmgr heal tests TestNSMGR_HealForwarder is still failing. It is probably failing because the interpose chain element does not reselect Forwarders if one does not become available. Signed-off-by: Ed Warnicke <hagbard@gmail.com> * heal: fix TestNSMGR_HealForwarder and remove grpc.WaitTillReady() and grpc.WithBlock() from sandbox.DialOptions() Signed-off-by: Ed Warnicke <hagbard@gmail.com> * Fixes failing tests Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Add healClient option Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Nov 11, 2021
…k@main PR link: networkservicemesh/sdk#1113 Commit: 0f652be Author: Artem Glazychev Date: 2021-11-11 19:50:13 +0700 Message: - Add healing feature (#1113) * Add begin.WithReselect option Signed-off-by: Ed Warnicke <hagbard@gmail.com> * begin: Merge new outside Requests with heal/refresh information Signed-off-by: Ed Warnicke <hagbard@gmail.com> * Add trimpath chain elements Signed-off-by: Ed Warnicke <hagbard@gmail.com> * [qfix] panic protection in dialer chain element Signed-off-by: Ed Warnicke <hagbard@gmail.com> * Very very rough first pass at heal. Signed-off-by: Ed Warnicke <hagbard@gmail.com> * Not quite working restoration of the nsmgr heal tests TestNSMGR_HealForwarder is still failing. It is probably failing because the interpose chain element does not reselect Forwarders if one does not become available. Signed-off-by: Ed Warnicke <hagbard@gmail.com> * heal: fix TestNSMGR_HealForwarder and remove grpc.WaitTillReady() and grpc.WithBlock() from sandbox.DialOptions() Signed-off-by: Ed Warnicke <hagbard@gmail.com> * Fixes failing tests Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Add healClient option Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Nov 11, 2021
…k@main PR link: networkservicemesh/sdk#1113 Commit: 0f652be Author: Artem Glazychev Date: 2021-11-11 19:50:13 +0700 Message: - Add healing feature (#1113) * Add begin.WithReselect option Signed-off-by: Ed Warnicke <hagbard@gmail.com> * begin: Merge new outside Requests with heal/refresh information Signed-off-by: Ed Warnicke <hagbard@gmail.com> * Add trimpath chain elements Signed-off-by: Ed Warnicke <hagbard@gmail.com> * [qfix] panic protection in dialer chain element Signed-off-by: Ed Warnicke <hagbard@gmail.com> * Very very rough first pass at heal. Signed-off-by: Ed Warnicke <hagbard@gmail.com> * Not quite working restoration of the nsmgr heal tests TestNSMGR_HealForwarder is still failing. It is probably failing because the interpose chain element does not reselect Forwarders if one does not become available. Signed-off-by: Ed Warnicke <hagbard@gmail.com> * heal: fix TestNSMGR_HealForwarder and remove grpc.WaitTillReady() and grpc.WithBlock() from sandbox.DialOptions() Signed-off-by: Ed Warnicke <hagbard@gmail.com> * Fixes failing tests Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Add healClient option Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
Nov 11, 2021
…k@main PR link: networkservicemesh/sdk#1113 Commit: 0f652be Author: Artem Glazychev Date: 2021-11-11 19:50:13 +0700 Message: - Add healing feature (#1113) * Add begin.WithReselect option Signed-off-by: Ed Warnicke <hagbard@gmail.com> * begin: Merge new outside Requests with heal/refresh information Signed-off-by: Ed Warnicke <hagbard@gmail.com> * Add trimpath chain elements Signed-off-by: Ed Warnicke <hagbard@gmail.com> * [qfix] panic protection in dialer chain element Signed-off-by: Ed Warnicke <hagbard@gmail.com> * Very very rough first pass at heal. Signed-off-by: Ed Warnicke <hagbard@gmail.com> * Not quite working restoration of the nsmgr heal tests TestNSMGR_HealForwarder is still failing. It is probably failing because the interpose chain element does not reselect Forwarders if one does not become available. Signed-off-by: Ed Warnicke <hagbard@gmail.com> * heal: fix TestNSMGR_HealForwarder and remove grpc.WaitTillReady() and grpc.WithBlock() from sandbox.DialOptions() Signed-off-by: Ed Warnicke <hagbard@gmail.com> * Fixes failing tests Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Add healClient option Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Nov 11, 2021
…k@main PR link: networkservicemesh/sdk#1113 Commit: 0f652be Author: Artem Glazychev Date: 2021-11-11 19:50:13 +0700 Message: - Add healing feature (#1113) * Add begin.WithReselect option Signed-off-by: Ed Warnicke <hagbard@gmail.com> * begin: Merge new outside Requests with heal/refresh information Signed-off-by: Ed Warnicke <hagbard@gmail.com> * Add trimpath chain elements Signed-off-by: Ed Warnicke <hagbard@gmail.com> * [qfix] panic protection in dialer chain element Signed-off-by: Ed Warnicke <hagbard@gmail.com> * Very very rough first pass at heal. Signed-off-by: Ed Warnicke <hagbard@gmail.com> * Not quite working restoration of the nsmgr heal tests TestNSMGR_HealForwarder is still failing. It is probably failing because the interpose chain element does not reselect Forwarders if one does not become available. Signed-off-by: Ed Warnicke <hagbard@gmail.com> * heal: fix TestNSMGR_HealForwarder and remove grpc.WaitTillReady() and grpc.WithBlock() from sandbox.DialOptions() Signed-off-by: Ed Warnicke <hagbard@gmail.com> * Fixes failing tests Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Add healClient option Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Nov 11, 2021
…k@main PR link: networkservicemesh/sdk#1113 Commit: 0f652be Author: Artem Glazychev Date: 2021-11-11 19:50:13 +0700 Message: - Add healing feature (#1113) * Add begin.WithReselect option Signed-off-by: Ed Warnicke <hagbard@gmail.com> * begin: Merge new outside Requests with heal/refresh information Signed-off-by: Ed Warnicke <hagbard@gmail.com> * Add trimpath chain elements Signed-off-by: Ed Warnicke <hagbard@gmail.com> * [qfix] panic protection in dialer chain element Signed-off-by: Ed Warnicke <hagbard@gmail.com> * Very very rough first pass at heal. Signed-off-by: Ed Warnicke <hagbard@gmail.com> * Not quite working restoration of the nsmgr heal tests TestNSMGR_HealForwarder is still failing. It is probably failing because the interpose chain element does not reselect Forwarders if one does not become available. Signed-off-by: Ed Warnicke <hagbard@gmail.com> * heal: fix TestNSMGR_HealForwarder and remove grpc.WaitTillReady() and grpc.WithBlock() from sandbox.DialOptions() Signed-off-by: Ed Warnicke <hagbard@gmail.com> * Fixes failing tests Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Add healClient option Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Nov 11, 2021
…k@main PR link: networkservicemesh/sdk#1113 Commit: 0f652be Author: Artem Glazychev Date: 2021-11-11 19:50:13 +0700 Message: - Add healing feature (#1113) * Add begin.WithReselect option Signed-off-by: Ed Warnicke <hagbard@gmail.com> * begin: Merge new outside Requests with heal/refresh information Signed-off-by: Ed Warnicke <hagbard@gmail.com> * Add trimpath chain elements Signed-off-by: Ed Warnicke <hagbard@gmail.com> * [qfix] panic protection in dialer chain element Signed-off-by: Ed Warnicke <hagbard@gmail.com> * Very very rough first pass at heal. Signed-off-by: Ed Warnicke <hagbard@gmail.com> * Not quite working restoration of the nsmgr heal tests TestNSMGR_HealForwarder is still failing. It is probably failing because the interpose chain element does not reselect Forwarders if one does not become available. Signed-off-by: Ed Warnicke <hagbard@gmail.com> * heal: fix TestNSMGR_HealForwarder and remove grpc.WaitTillReady() and grpc.WithBlock() from sandbox.DialOptions() Signed-off-by: Ed Warnicke <hagbard@gmail.com> * Fixes failing tests Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Add healClient option Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds new healing feature
Continuation of #1107