Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qfix] Delete only generated vxlan vni on error #1177

Merged
merged 1 commit into from
Nov 25, 2021

Conversation

glazychev-art
Copy link
Contributor

Signed-off-by: Artem Glazychev artem.glazychev@xored.com

Description

We need to delete vni on error only if we generated it on that Request

Issue link

Fixes: networkservicemesh/integration-k8s-packet#166

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing locally
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
@denis-tingaikin denis-tingaikin merged commit 73e9530 into networkservicemesh:main Nov 25, 2021
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Nov 25, 2021
…k@main

PR link: networkservicemesh/sdk#1177

Commit: 73e9530
Author: Artem Glazychev
Date: 2021-11-25 14:27:25 +0700
Message:
  - [qfix] Delete only generated vxlan vni on error (#1177)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Nov 25, 2021
…k@main

PR link: networkservicemesh/sdk#1177

Commit: 73e9530
Author: Artem Glazychev
Date: 2021-11-25 14:27:25 +0700
Message:
  - [qfix] Delete only generated vxlan vni on error (#1177)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Nov 25, 2021
…k@main

PR link: networkservicemesh/sdk#1177

Commit: 73e9530
Author: Artem Glazychev
Date: 2021-11-25 14:27:25 +0700
Message:
  - [qfix] Delete only generated vxlan vni on error (#1177)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Nov 25, 2021
…k@main

PR link: networkservicemesh/sdk#1177

Commit: 73e9530
Author: Artem Glazychev
Date: 2021-11-25 14:27:25 +0700
Message:
  - [qfix] Delete only generated vxlan vni on error (#1177)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Nov 25, 2021
…k@main

PR link: networkservicemesh/sdk#1177

Commit: 73e9530
Author: Artem Glazychev
Date: 2021-11-25 14:27:25 +0700
Message:
  - [qfix] Delete only generated vxlan vni on error (#1177)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Nov 25, 2021
…k@main

PR link: networkservicemesh/sdk#1177

Commit: 73e9530
Author: Artem Glazychev
Date: 2021-11-25 14:27:25 +0700
Message:
  - [qfix] Delete only generated vxlan vni on error (#1177)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Nov 25, 2021
…k@main

PR link: networkservicemesh/sdk#1177

Commit: 73e9530
Author: Artem Glazychev
Date: 2021-11-25 14:27:25 +0700
Message:
  - [qfix] Delete only generated vxlan vni on error (#1177)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Nov 25, 2021
…k@main

PR link: networkservicemesh/sdk#1177

Commit: 73e9530
Author: Artem Glazychev
Date: 2021-11-25 14:27:25 +0700
Message:
  - [qfix] Delete only generated vxlan vni on error (#1177)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Nov 25, 2021
…k@main

PR link: networkservicemesh/sdk#1177

Commit: 73e9530
Author: Artem Glazychev
Date: 2021-11-25 14:27:25 +0700
Message:
  - [qfix] Delete only generated vxlan vni on error (#1177)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestRemote_nsmgr_restart.TestHeal/TestRemote_nsmgr_restart is unstable
3 participants