Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opentelemetry support #1205

Merged
Merged
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
9073f66
Update protobuf to v1.26.0 needed for opentelemetry
glazychev-art Jun 18, 2021
2b24e9c
Add opentelemetry support
glazychev-art Dec 14, 2020
f8e1fa2
fixes
NikitaSkrynnik Dec 27, 2021
9bed5e4
update dependencies
NikitaSkrynnik Dec 3, 2021
8715489
fixes due to version update
NikitaSkrynnik Dec 20, 2021
ab870cf
add jaeger exporter
NikitaSkrynnik Dec 20, 2021
a922d07
goleaks disappeared somewhere
NikitaSkrynnik Dec 20, 2021
5cb9784
minor fixes for jaeger
NikitaSkrynnik Dec 20, 2021
5c3d705
add zipkin exporter
NikitaSkrynnik Dec 20, 2021
6c03a75
go leaks related to transfer of the spans
NikitaSkrynnik Dec 21, 2021
5b3bb3f
add opentelemetry collector support
NikitaSkrynnik Dec 21, 2021
838b665
add metrics support
NikitaSkrynnik Dec 22, 2021
4c17d3c
add metrics test
NikitaSkrynnik Dec 22, 2021
ce24e51
add README.md file
NikitaSkrynnik Dec 27, 2021
3f09405
fixes after cherry-pick
NikitaSkrynnik Dec 27, 2021
5f8a2c3
more fixes
NikitaSkrynnik Dec 27, 2021
d5a5216
run go mod tidy
NikitaSkrynnik Dec 27, 2021
3800030
lint fixes
NikitaSkrynnik Dec 27, 2021
52736b8
revert test and updatepath files
LilFloppa Dec 30, 2021
563b91e
revert refresh/client.go file
NikitaSkrynnik Dec 30, 2021
9e58ffa
delete meter_helper
NikitaSkrynnik Dec 30, 2021
9c989d9
fill empty event names + delete instrumentationname
NikitaSkrynnik Dec 30, 2021
b0fb532
Revert "revert refresh/client.go file"
NikitaSkrynnik Dec 30, 2021
b7c407f
remove opentracing
NikitaSkrynnik Jan 11, 2022
33209ef
fix linter issue
NikitaSkrynnik Jan 12, 2022
c9de654
change TELEMETRY env value
NikitaSkrynnik Jan 12, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
goleaks disappeared somewhere
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
  • Loading branch information
NikitaSkrynnik committed Jan 12, 2022
commit a922d07ee59cb5791c2d6d128248e74d0097cc7b
6 changes: 6 additions & 0 deletions pkg/tools/jaeger/jaeger.go
Original file line number Diff line number Diff line change
@@ -34,6 +34,12 @@ func InitExporter(ctx context.Context, exporterURL string) trace.SpanExporter {
}

exporter, err := jaeger.New(jaeger.WithCollectorEndpoint(jaeger.WithEndpoint(exporterURL)))
go func() {
<-ctx.Done()
if err := exporter.Shutdown(context.Background()); err != nil {
log.FromContext(ctx).Fatal(err)
}
}()

if err != nil {
log.FromContext(ctx).Fatal(err)
6 changes: 4 additions & 2 deletions pkg/tools/opentelemetry/opentelemetry.go
Original file line number Diff line number Diff line change
@@ -102,6 +102,7 @@ func Init(ctx context.Context, exporter sdktrace.SpanExporter, service string) i
// span processor to aggregate spans before export.
bsp := sdktrace.NewBatchSpanProcessor(exporter)
tracerProvider := sdktrace.NewTracerProvider(
sdktrace.WithSampler(sdktrace.AlwaysSample()),
sdktrace.WithSpanProcessor(bsp),
sdktrace.WithResource(res),
)
@@ -111,8 +112,9 @@ func Init(ctx context.Context, exporter sdktrace.SpanExporter, service string) i
log.FromContext(ctx).Fatal(err)
}

bsp.Shutdown(context.Background())
exporter.Shutdown(context.Background())
if err := bsp.Shutdown(context.Background()); err != nil {
log.FromContext(ctx).Fatal(err)
}
}()

otel.SetTracerProvider(tracerProvider)