Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: nsmgr WithrRgistry option has useless registry dial options #1218

Merged
merged 2 commits into from
Jan 26, 2022
Merged

Refactor: nsmgr WithrRgistry option has useless registry dial options #1218

merged 2 commits into from
Jan 26, 2022

Conversation

denis-tingaikin
Copy link
Member

Signed-off-by: Denis Tingaikin denis.tingajkin@xored.com

Description

regDialOptions are not used more.

Issue link

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

@denis-tingaikin
refactor nsmgr withregistry option
136cfe1 
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
@denis-tingaikin
fix tests
07e0af7 
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
@edwarnicke edwarnicke merged commit 17ea214 into networkservicemesh:main Jan 26, 2022
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Jan 26, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
b94ee93 
…k@main

PR link: networkservicemesh/sdk#1218

Commit: 17ea214
Author: Denis Tingaikin
Date: 2022-01-26 22:38:00 +0300
Message:
  - Refactor: nsmgr WithrRgistry option has useless registry dial options (#1218)
* refactor nsmgr withregistry option

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

* fix tests

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Jan 26, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
6fd9d42 
…k@main

PR link: networkservicemesh/sdk#1218

Commit: 17ea214
Author: Denis Tingaikin
Date: 2022-01-26 22:38:00 +0300
Message:
  - Refactor: nsmgr WithrRgistry option has useless registry dial options (#1218)
* refactor nsmgr withregistry option

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

* fix tests

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Jan 26, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
2024b57 
…k@main

PR link: networkservicemesh/sdk#1218

Commit: 17ea214
Author: Denis Tingaikin
Date: 2022-01-26 22:38:00 +0300
Message:
  - Refactor: nsmgr WithrRgistry option has useless registry dial options (#1218)
* refactor nsmgr withregistry option

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

* fix tests

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Jan 26, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
5153c54 
…k@main

PR link: networkservicemesh/sdk#1218

Commit: 17ea214
Author: Denis Tingaikin
Date: 2022-01-26 22:38:00 +0300
Message:
  - Refactor: nsmgr WithrRgistry option has useless registry dial options (#1218)
* refactor nsmgr withregistry option

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

* fix tests

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Jan 26, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
12d53a2 
…k@main

PR link: networkservicemesh/sdk#1218

Commit: 17ea214
Author: Denis Tingaikin
Date: 2022-01-26 22:38:00 +0300
Message:
  - Refactor: nsmgr WithrRgistry option has useless registry dial options (#1218)
* refactor nsmgr withregistry option

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

* fix tests

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Jan 26, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
b49cd88 
…k@main

PR link: networkservicemesh/sdk#1218

Commit: 17ea214
Author: Denis Tingaikin
Date: 2022-01-26 22:38:00 +0300
Message:
  - Refactor: nsmgr WithrRgistry option has useless registry dial options (#1218)
* refactor nsmgr withregistry option

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

* fix tests

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Jan 26, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
e18d3ef 
…k@main

PR link: networkservicemesh/sdk#1218

Commit: 17ea214
Author: Denis Tingaikin
Date: 2022-01-26 22:38:00 +0300
Message:
  - Refactor: nsmgr WithrRgistry option has useless registry dial options (#1218)
* refactor nsmgr withregistry option

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

* fix tests

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Jan 26, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
766a94a 
…k@main

PR link: networkservicemesh/sdk#1218

Commit: 17ea214
Author: Denis Tingaikin
Date: 2022-01-26 22:38:00 +0300
Message:
  - Refactor: nsmgr WithrRgistry option has useless registry dial options (#1218)
* refactor nsmgr withregistry option

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

* fix tests

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Jan 26, 2022
Merged
Merged
Merged
Merged
Merged
edwarnicke pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Jan 27, 2022
@nsmbot @denis-tingaikin
Update from update/networkservicemesh/sdk (#447)
18ade83 
* Update go.mod and go.sum to latest version from networkservicemesh/sdk@main
PR link: networkservicemesh/sdk#1218

Commit: 17ea214
Author: Denis Tingaikin
Date: 2022-01-26 22:38:00 +0300
Message:
  - Refactor: nsmgr WithrRgistry option has useless registry dial options (#1218)
* refactor nsmgr withregistry option

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

* fix tests

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>

* fix build

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
Co-authored-by: Denis Tingaikin <denis.tingajkin@xored.com>
nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this pull request Jan 27, 2022
Update go.mod and go.sum to latest version from networkservicemesh/cm…
f1c85e3 
…d-nsmgr@main

PR link: networkservicemesh/cmd-nsmgr#447

Commit: 18ade83
Author: Network Service Mesh Bot
Date: 2022-01-27 12:52:04 -0600
Message:
  - Update from update/networkservicemesh/sdk (#447)
* Update go.mod and go.sum to latest version from networkservicemesh/sdk@main
PR link: networkservicemesh/sdk#1218

Commit: 17ea214
Author: Denis Tingaikin
Date: 2022-01-26 22:38:00 +0300
Message:
    - Refactor: nsmgr WithrRgistry option has useless registry dial options (#1218)
* refactor nsmgr withregistry option

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

* fix tests

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>

* fix build

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@nsmbot nsmbot mentioned this pull request Jan 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denis-tingaikin @edwarnicke