Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete label matching #1244

Merged

Conversation

NikitaSkrynnik
Copy link
Contributor

@NikitaSkrynnik NikitaSkrynnik commented Mar 15, 2022

Signed-off-by: Nikita Skrynnik nikita.skrynnik@xored.com

Description

Temporarily delete label-matching for NSEs. CI fails because of this (networkservicemesh/integration-k8s-kind#605). Label-matching will be reworked in this issue: #1239

Issue link

#1239

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
@denis-tingaikin denis-tingaikin merged commit 288caa7 into networkservicemesh:main Mar 16, 2022
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Mar 16, 2022
…k@main

PR link: networkservicemesh/sdk#1244

Commit: 288caa7
Author: Nikita Skrynnik
Date: 2022-03-16 17:12:37 +0700
Message:
  - Delete label matching (#1244)
* delete label matching (for ci)

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix Test_AwareNSEs

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix Test_AwareNSEs timeout

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Mar 16, 2022
…k@main

PR link: networkservicemesh/sdk#1244

Commit: 288caa7
Author: Nikita Skrynnik
Date: 2022-03-16 17:12:37 +0700
Message:
  - Delete label matching (#1244)
* delete label matching (for ci)

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix Test_AwareNSEs

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix Test_AwareNSEs timeout

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Mar 16, 2022
…k@main

PR link: networkservicemesh/sdk#1244

Commit: 288caa7
Author: Nikita Skrynnik
Date: 2022-03-16 17:12:37 +0700
Message:
  - Delete label matching (#1244)
* delete label matching (for ci)

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix Test_AwareNSEs

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix Test_AwareNSEs timeout

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Mar 16, 2022
…k@main

PR link: networkservicemesh/sdk#1244

Commit: 288caa7
Author: Nikita Skrynnik
Date: 2022-03-16 17:12:37 +0700
Message:
  - Delete label matching (#1244)
* delete label matching (for ci)

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix Test_AwareNSEs

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix Test_AwareNSEs timeout

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Mar 16, 2022
…k@main

PR link: networkservicemesh/sdk#1244

Commit: 288caa7
Author: Nikita Skrynnik
Date: 2022-03-16 17:12:37 +0700
Message:
  - Delete label matching (#1244)
* delete label matching (for ci)

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix Test_AwareNSEs

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix Test_AwareNSEs timeout

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Mar 16, 2022
…k@main

PR link: networkservicemesh/sdk#1244

Commit: 288caa7
Author: Nikita Skrynnik
Date: 2022-03-16 17:12:37 +0700
Message:
  - Delete label matching (#1244)
* delete label matching (for ci)

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix Test_AwareNSEs

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix Test_AwareNSEs timeout

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Mar 16, 2022
…k@main

PR link: networkservicemesh/sdk#1244

Commit: 288caa7
Author: Nikita Skrynnik
Date: 2022-03-16 17:12:37 +0700
Message:
  - Delete label matching (#1244)
* delete label matching (for ci)

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix Test_AwareNSEs

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix Test_AwareNSEs timeout

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Mar 16, 2022
…k@main

PR link: networkservicemesh/sdk#1244

Commit: 288caa7
Author: Nikita Skrynnik
Date: 2022-03-16 17:12:37 +0700
Message:
  - Delete label matching (#1244)
* delete label matching (for ci)

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix Test_AwareNSEs

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix Test_AwareNSEs timeout

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Mar 16, 2022
…k@main

PR link: networkservicemesh/sdk#1244

Commit: 288caa7
Author: Nikita Skrynnik
Date: 2022-03-16 17:12:37 +0700
Message:
  - Delete label matching (#1244)
* delete label matching (for ci)

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix Test_AwareNSEs

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix Test_AwareNSEs timeout

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Mar 16, 2022
…k@main

PR link: networkservicemesh/sdk#1244

Commit: 288caa7
Author: Nikita Skrynnik
Date: 2022-03-16 17:12:37 +0700
Message:
  - Delete label matching (#1244)
* delete label matching (for ci)

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix Test_AwareNSEs

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix Test_AwareNSEs timeout

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@NikitaSkrynnik NikitaSkrynnik deleted the delete-matching branch June 19, 2022 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants