-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enable trace logging only if logrus.LogLevel() is TRACE #1273
Merged
edwarnicke
merged 1 commit into
networkservicemesh:main
from
denis-tingaikin:enable-logging-only-if-log-level-is-trace
Apr 27, 2022
Merged
fix: enable trace logging only if logrus.LogLevel() is TRACE #1273
edwarnicke
merged 1 commit into
networkservicemesh:main
from
denis-tingaikin:enable-logging-only-if-log-level-is-trace
Apr 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
denis-tingaikin
changed the title
fix: enable trace logging only if logrus.TraceLevel is TRACE
fix: enable trace logging only if logrus.LogLevel() is TRACE
Apr 27, 2022
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
Apr 27, 2022
…k@main PR link: networkservicemesh/sdk#1273 Commit: 241ef75 Author: Denis Tingaikin Date: 2022-04-28 01:41:49 +0300 Message: - enable trace logging only if logrus.TraceLevel is TRACE (#1273) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Apr 27, 2022
…k@main PR link: networkservicemesh/sdk#1273 Commit: 241ef75 Author: Denis Tingaikin Date: 2022-04-28 01:41:49 +0300 Message: - enable trace logging only if logrus.TraceLevel is TRACE (#1273) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Apr 27, 2022
…k@main PR link: networkservicemesh/sdk#1273 Commit: 241ef75 Author: Denis Tingaikin Date: 2022-04-28 01:41:49 +0300 Message: - enable trace logging only if logrus.TraceLevel is TRACE (#1273) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Apr 27, 2022
…k@main PR link: networkservicemesh/sdk#1273 Commit: 241ef75 Author: Denis Tingaikin Date: 2022-04-28 01:41:49 +0300 Message: - enable trace logging only if logrus.TraceLevel is TRACE (#1273) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Apr 27, 2022
…k@main PR link: networkservicemesh/sdk#1273 Commit: 241ef75 Author: Denis Tingaikin Date: 2022-04-28 01:41:49 +0300 Message: - enable trace logging only if logrus.TraceLevel is TRACE (#1273) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Apr 27, 2022
…k@main PR link: networkservicemesh/sdk#1273 Commit: 241ef75 Author: Denis Tingaikin Date: 2022-04-28 01:41:49 +0300 Message: - enable trace logging only if logrus.TraceLevel is TRACE (#1273) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
Apr 27, 2022
…k@main PR link: networkservicemesh/sdk#1273 Commit: 241ef75 Author: Denis Tingaikin Date: 2022-04-28 01:41:49 +0300 Message: - enable trace logging only if logrus.TraceLevel is TRACE (#1273) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Apr 27, 2022
…k@main PR link: networkservicemesh/sdk#1273 Commit: 241ef75 Author: Denis Tingaikin Date: 2022-04-28 01:41:49 +0300 Message: - enable trace logging only if logrus.TraceLevel is TRACE (#1273) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-ipam-vl3
that referenced
this pull request
Apr 27, 2022
…k@main PR link: networkservicemesh/sdk#1273 Commit: 241ef75 Author: Denis Tingaikin Date: 2022-04-28 01:41:49 +0300 Message: - enable trace logging only if logrus.TraceLevel is TRACE (#1273) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Apr 27, 2022
…k@main PR link: networkservicemesh/sdk#1273 Commit: 241ef75 Author: Denis Tingaikin Date: 2022-04-28 01:41:49 +0300 Message: - enable trace logging only if logrus.TraceLevel is TRACE (#1273) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Apr 27, 2022
…k@main PR link: networkservicemesh/sdk#1273 Commit: 241ef75 Author: Denis Tingaikin Date: 2022-04-28 01:41:49 +0300 Message: - enable trace logging only if logrus.TraceLevel is TRACE (#1273) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-map-ip-k8s
that referenced
this pull request
Apr 27, 2022
…k@main PR link: networkservicemesh/sdk#1273 Commit: 241ef75 Author: Denis Tingaikin Date: 2022-04-28 01:41:49 +0300 Message: - enable trace logging only if logrus.TraceLevel is TRACE (#1273) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Apr 27, 2022
denis-tingaikin
added a commit
that referenced
this pull request
Apr 29, 2022
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Denis Tingaikin denis.tingajkin@xored.com
Description
This PR temporary fixes the problem with logging from the community for all NSM applications.
Issue link
We're planning to rework and simplify logging within #1272
How Has This Been Tested?
Types of changes