Reusable workflows #1278
Merged
Reusable workflows #1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikitaSkrynnik
force-pushed
the
reusable-workflows
branch
3 times, most recently
from
be924fc to
08d7b86
Compare
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
NikitaSkrynnik
force-pushed
the
reusable-workflows
branch
from
c29e89d to
7e84daa
Compare
edwarnicke
reviewed
May 12, 2022
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| MAXIMUM_RETRIES: 25 | ||
| if: ${{ github.event.workflow_run.conclusion == 'success' && github.actor == 'nsmbot'}} | ||
| uses: networkservicemesh/.github/.github/workflows/automerge.yaml@main |
There was a problem hiding this comment.
Do we want to depend on a branch here rather than a specific point?
I can see tradeoffs either way... so the real question is 'have we thought it through' ?
There was a problem hiding this comment.
@edwarnicke I've created a ticket for v1.5.0 networkservicemesh/.github#6
|
Overall other than my branch vs commit comment above, I'm good with this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue link
networkservicemesh/.github#4
How Has This Been Tested?
Types of changes