[WIP] Vl3 next-hop fix #1309
Merged
[WIP] Vl3 next-hop fix #1309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
|
@edwarnicke I think this can be merged right now. Note: we can create release base on rc-2 branches for case if these changes are unstable OR revert this |
denis-tingaikin
approved these changes
Jun 3, 2022
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Jun 3, 2022
…k@main PR link: networkservicemesh/sdk#1309 Commit: 6abdf1e Author: Artem Glazychev Date: 2022-06-04 02:10:23 +0700 Message: - Vl3 next-hop fix (#1309) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
Jun 3, 2022
…k@main PR link: networkservicemesh/sdk#1309 Commit: 6abdf1e Author: Artem Glazychev Date: 2022-06-04 02:10:23 +0700 Message: - Vl3 next-hop fix (#1309) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-map-ip-k8s
that referenced
this pull request
Jun 3, 2022
…k@main PR link: networkservicemesh/sdk#1309 Commit: 6abdf1e Author: Artem Glazychev Date: 2022-06-04 02:10:23 +0700 Message: - Vl3 next-hop fix (#1309) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-ipam-vl3
that referenced
this pull request
Jun 3, 2022
…k@main PR link: networkservicemesh/sdk#1309 Commit: 6abdf1e Author: Artem Glazychev Date: 2022-06-04 02:10:23 +0700 Message: - Vl3 next-hop fix (#1309) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Jun 3, 2022
…k@main PR link: networkservicemesh/sdk#1309 Commit: 6abdf1e Author: Artem Glazychev Date: 2022-06-04 02:10:23 +0700 Message: - Vl3 next-hop fix (#1309) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Jun 3, 2022
…k@main PR link: networkservicemesh/sdk#1309 Commit: 6abdf1e Author: Artem Glazychev Date: 2022-06-04 02:10:23 +0700 Message: - Vl3 next-hop fix (#1309) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Jun 3, 2022
…k@main PR link: networkservicemesh/sdk#1309 Commit: 6abdf1e Author: Artem Glazychev Date: 2022-06-04 02:10:23 +0700 Message: - Vl3 next-hop fix (#1309) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Jun 3, 2022
…k@main PR link: networkservicemesh/sdk#1309 Commit: 6abdf1e Author: Artem Glazychev Date: 2022-06-04 02:10:23 +0700 Message: - Vl3 next-hop fix (#1309) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
Jun 3, 2022
…k@main PR link: networkservicemesh/sdk#1309 Commit: 6abdf1e Author: Artem Glazychev Date: 2022-06-04 02:10:23 +0700 Message: - Vl3 next-hop fix (#1309) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Jun 3, 2022
…k@main PR link: networkservicemesh/sdk#1309 Commit: 6abdf1e Author: Artem Glazychev Date: 2022-06-04 02:10:23 +0700 Message: - Vl3 next-hop fix (#1309) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Jun 3, 2022
…k@main PR link: networkservicemesh/sdk#1309 Commit: 6abdf1e Author: Artem Glazychev Date: 2022-06-04 02:10:23 +0700 Message: - Vl3 next-hop fix (#1309) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Jun 3, 2022
…k@main PR link: networkservicemesh/sdk#1309 Commit: 6abdf1e Author: Artem Glazychev Date: 2022-06-04 02:10:23 +0700 Message: - Vl3 next-hop fix (#1309) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Jun 3, 2022
@glazychev-art Could we open an issue for this for v1.5? |
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
Jun 6, 2022
…k@main PR link: networkservicemesh/sdk#1309 Commit: 6abdf1e Author: Artem Glazychev Date: 2022-06-04 02:10:23 +0700 Message: - Vl3 next-hop fix (#1309) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Jun 6, 2022
…k@main PR link: networkservicemesh/sdk#1309 Commit: 6abdf1e Author: Artem Glazychev Date: 2022-06-04 02:10:23 +0700 Message: - Vl3 next-hop fix (#1309) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Jun 6, 2022
…k@main PR link: networkservicemesh/sdk#1309 Commit: 6abdf1e Author: Artem Glazychev Date: 2022-06-04 02:10:23 +0700 Message: - Vl3 next-hop fix (#1309) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artem Glazychev artem.glazychev@xored.com
Description
Tested only with this test on GKE - https://github.com/networkservicemesh/deployments-k8s/tree/main/examples/features/vl3-basic
Would like to find out, why this functionality is not working - https://github.com/networkservicemesh/sdk-kernel/blob/main/pkg/kernel/networkservice/connectioncontextkernel/ipcontext/routes/common.go#L64
Issue link
How Has This Been Tested?
Types of changes