Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add replaceNSEName chain element #1328

Merged
merged 2 commits into from
Jul 20, 2022
Merged

Add replaceNSEName chain element #1328

merged 2 commits into from
Jul 20, 2022

Conversation

glazychev-art
Copy link
Contributor

@glazychev-art glazychev-art commented Jul 19, 2022 •
edited
Loading

Signed-off-by: Artem Glazychev artem.glazychev@xored.com

Description

Split replacelabels chain element to replacelabels and replaceNSEName
We need to use already discovered NSE on refresh

Issue link

networkservicemesh/deployments-k8s#6305

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

@glazychev-art
Add replaceNSEName chain element
f3faef5 
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
denis-tingaikin
denis-tingaikin reviewed Jul 20, 2022
View reviewed changes
pkg/networkservice/common/replacelabels/client.go
@@ -1,4 +1,4 @@
// Copyright (c) 2021 Doc.ai and/or its affiliates.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we return this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, done

pkg/networkservice/chains/nsmgr/suite_test.go Outdated
@@ -795,6 +796,7 @@ func additionalFunctionalityChain(ctx context.Context, clientURL *url.URL, clien
client.WithAdditionalFunctionality(
mechanismtranslation.NewClient(),
replacelabels.NewClient(labels),
replacensename.NewClient(),
Copy link
Member

@denis-tingaikin denis-tingaikin Jul 20, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im mostly sure that we could face with the similar issue in future (when we need to replace something in pass through requests)

Should we create a pkg like passthrough and concatenate all needed replace elements?

Something like

package passthrough

func NewClient(labels map[string]string) networkservice.NetworkServiceClient {
return chain.NewClient(
          replacelabels.NewClient(labels),
          replacensename.NewClient(),
     )

}

And use passthrough chain in firewall nses?

/cc @edwarnicke

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good idea, thanks!
Done

@glazychev-art
Create passthrough chain element
d303544 
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
@denis-tingaikin denis-tingaikin merged commit 7349b1f into networkservicemesh:main Jul 20, 2022
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Jul 20, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
596f34d 
…k@main

PR link: networkservicemesh/sdk#1328

Commit: 7349b1f
Author: Artem Glazychev
Date: 2022-07-20 16:29:51 +0700
Message:
  - Add replaceNSEName chain element (#1328)
* Add replaceNSEName chain element

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Create passthrough chain element

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Jul 20, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
8c8853c 
…k@main

PR link: networkservicemesh/sdk#1328

Commit: 7349b1f
Author: Artem Glazychev
Date: 2022-07-20 16:29:51 +0700
Message:
  - Add replaceNSEName chain element (#1328)
* Add replaceNSEName chain element

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Create passthrough chain element

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Jul 20, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
13765cf 
…k@main

PR link: networkservicemesh/sdk#1328

Commit: 7349b1f
Author: Artem Glazychev
Date: 2022-07-20 16:29:51 +0700
Message:
  - Add replaceNSEName chain element (#1328)
* Add replaceNSEName chain element

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Create passthrough chain element

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Jul 20, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
de39dce 
…k@main

PR link: networkservicemesh/sdk#1328

Commit: 7349b1f
Author: Artem Glazychev
Date: 2022-07-20 16:29:51 +0700
Message:
  - Add replaceNSEName chain element (#1328)
* Add replaceNSEName chain element

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Create passthrough chain element

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Jul 20, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
5e3ac69 
…k@main

PR link: networkservicemesh/sdk#1328

Commit: 7349b1f
Author: Artem Glazychev
Date: 2022-07-20 16:29:51 +0700
Message:
  - Add replaceNSEName chain element (#1328)
* Add replaceNSEName chain element

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Create passthrough chain element

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Jul 20, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
bbd6567 
…k@main

PR link: networkservicemesh/sdk#1328

Commit: 7349b1f
Author: Artem Glazychev
Date: 2022-07-20 16:29:51 +0700
Message:
  - Add replaceNSEName chain element (#1328)
* Add replaceNSEName chain element

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Create passthrough chain element

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Jul 20, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
ee89704 
…k@main

PR link: networkservicemesh/sdk#1328

Commit: 7349b1f
Author: Artem Glazychev
Date: 2022-07-20 16:29:51 +0700
Message:
  - Add replaceNSEName chain element (#1328)
* Add replaceNSEName chain element

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Create passthrough chain element

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Jul 20, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
b56003b 
…k@main

PR link: networkservicemesh/sdk#1328

Commit: 7349b1f
Author: Artem Glazychev
Date: 2022-07-20 16:29:51 +0700
Message:
  - Add replaceNSEName chain element (#1328)
* Add replaceNSEName chain element

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Create passthrough chain element

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Jul 20, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
0375b81 
…k@main

PR link: networkservicemesh/sdk#1328

Commit: 7349b1f
Author: Artem Glazychev
Date: 2022-07-20 16:29:51 +0700
Message:
  - Add replaceNSEName chain element (#1328)
* Add replaceNSEName chain element

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Create passthrough chain element

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Jul 20, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
67be942 
…k@main

PR link: networkservicemesh/sdk#1328

Commit: 7349b1f
Author: Artem Glazychev
Date: 2022-07-20 16:29:51 +0700
Message:
  - Add replaceNSEName chain element (#1328)
* Add replaceNSEName chain element

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Create passthrough chain element

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Jul 20, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
ef91cce 
…k@main

PR link: networkservicemesh/sdk#1328

Commit: 7349b1f
Author: Artem Glazychev
Date: 2022-07-20 16:29:51 +0700
Message:
  - Add replaceNSEName chain element (#1328)
* Add replaceNSEName chain element

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Create passthrough chain element

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Jul 20, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
1366633 
…k@main

PR link: networkservicemesh/sdk#1328

Commit: 7349b1f
Author: Artem Glazychev
Date: 2022-07-20 16:29:51 +0700
Message:
  - Add replaceNSEName chain element (#1328)
* Add replaceNSEName chain element

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Create passthrough chain element

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Jul 20, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Jul 20, 2022
Merged
Merged
anastasia-malysheva pushed a commit to anastasia-malysheva/sdk that referenced this pull request Jul 27, 2022
@glazychev-art @anastasia-malysheva
Add replaceNSEName chain element (networkservicemesh#1328)
849c70a 
* Add replaceNSEName chain element

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Create passthrough chain element

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

@NikitaSkrynnik NikitaSkrynnik Awaiting requested review from NikitaSkrynnik

@anastasia-malysheva anastasia-malysheva Awaiting requested review from anastasia-malysheva

@MarinaShustowa MarinaShustowa Awaiting requested review from MarinaShustowa

@ThetaDR ThetaDR Awaiting requested review from ThetaDR

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glazychev-art @denis-tingaikin