Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for vl3_dns #1332

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Fixes for vl3_dns #1332

merged 1 commit into from
Jul 27, 2022

Conversation

glazychev-art
Copy link
Contributor

@glazychev-art glazychev-art commented Jul 27, 2022 •
edited
Loading

Signed-off-by: Artem Glazychev artem.glazychev@xored.com

Description

  1. The main fix is GetSrcIPRoutes -> GetSrcRoutes
  2. Prevented dnsContext duplication
  3. Other changes because of linter cyclomatic complexity

Issue link

networkservicemesh/deployments-k8s#6774

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

@glazychev-art
Fixes for vl3_dns
79f3953 
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
@denis-tingaikin denis-tingaikin merged commit 599be65 into networkservicemesh:main Jul 27, 2022
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Jul 27, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
279b581 
…k@main

PR link: networkservicemesh/sdk#1332

Commit: 599be65
Author: Artem Glazychev
Date: 2022-07-27 18:44:59 +0700
Message:
  - Fixes for vl3_dns (#1332)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Jul 27, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
3598c3f 
…k@main

PR link: networkservicemesh/sdk#1332

Commit: 599be65
Author: Artem Glazychev
Date: 2022-07-27 18:44:59 +0700
Message:
  - Fixes for vl3_dns (#1332)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Jul 27, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
0d06c1e 
…k@main

PR link: networkservicemesh/sdk#1332

Commit: 599be65
Author: Artem Glazychev
Date: 2022-07-27 18:44:59 +0700
Message:
  - Fixes for vl3_dns (#1332)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this pull request Jul 27, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
9ae9a9d 
…k@main

PR link: networkservicemesh/sdk#1332

Commit: 599be65
Author: Artem Glazychev
Date: 2022-07-27 18:44:59 +0700
Message:
  - Fixes for vl3_dns (#1332)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Jul 27, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
26b88c2 
…k@main

PR link: networkservicemesh/sdk#1332

Commit: 599be65
Author: Artem Glazychev
Date: 2022-07-27 18:44:59 +0700
Message:
  - Fixes for vl3_dns (#1332)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Jul 27, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
0d0f0b3 
…k@main

PR link: networkservicemesh/sdk#1332

Commit: 599be65
Author: Artem Glazychev
Date: 2022-07-27 18:44:59 +0700
Message:
  - Fixes for vl3_dns (#1332)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Jul 27, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
cba4676 
…k@main

PR link: networkservicemesh/sdk#1332

Commit: 599be65
Author: Artem Glazychev
Date: 2022-07-27 18:44:59 +0700
Message:
  - Fixes for vl3_dns (#1332)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Jul 27, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
17b4a53 
…k@main

PR link: networkservicemesh/sdk#1332

Commit: 599be65
Author: Artem Glazychev
Date: 2022-07-27 18:44:59 +0700
Message:
  - Fixes for vl3_dns (#1332)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Jul 27, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
1cb4f96 
…k@main

PR link: networkservicemesh/sdk#1332

Commit: 599be65
Author: Artem Glazychev
Date: 2022-07-27 18:44:59 +0700
Message:
  - Fixes for vl3_dns (#1332)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Jul 27, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
6d51c61 
…k@main

PR link: networkservicemesh/sdk#1332

Commit: 599be65
Author: Artem Glazychev
Date: 2022-07-27 18:44:59 +0700
Message:
  - Fixes for vl3_dns (#1332)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Jul 27, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
4450cfa 
…k@main

PR link: networkservicemesh/sdk#1332

Commit: 599be65
Author: Artem Glazychev
Date: 2022-07-27 18:44:59 +0700
Message:
  - Fixes for vl3_dns (#1332)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Jul 27, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
cc214c6 
…k@main

PR link: networkservicemesh/sdk#1332

Commit: 599be65
Author: Artem Glazychev
Date: 2022-07-27 18:44:59 +0700
Message:
  - Fixes for vl3_dns (#1332)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Jul 27, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
d65508c 
…k@main

PR link: networkservicemesh/sdk#1332

Commit: 599be65
Author: Artem Glazychev
Date: 2022-07-27 18:44:59 +0700
Message:
  - Fixes for vl3_dns (#1332)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Jul 27, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glazychev-art @denis-tingaikin