Moved to using a generic map instead of generated maps #1350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwarnicke
force-pushed
the
genericmap
branch
3 times, most recently
from
a972cb7 to
88aa556
Compare
|
I suspect that after networkservicemesh/.github#15 is merged that golangci-lint will pass. |
Signed-off-by: Ed Warnicke <hagbard@gmail.com>
edwarnicke
force-pushed
the
genericmap
branch
from
88aa556 to
375c4f8
Compare
There was a problem hiding this comment.
@edwarnicke I very love this PR :)
FYI: Now generics are support by golangci linter. See at my commit with update for nsmctl. repo networkservicemesh/nsmctl@8328d71
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ed Warnicke hagbard@gmail.com
Description
Issue link
How Has This Been Tested?
Types of changes