Don't trace gRPC "Canceled" errors #1353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denis-tingaikin
approved these changes
Sep 13, 2022
ghost
force-pushed
the
dont-trace-cancels
branch
from
654c28f to
0dfc21e
Compare
|
I think that I signed the commit but please let me know if something's wrong as I'm new to git signatures. |
|
@caboteria Seems like it still requires to sign the commit. See at DCO check https://github.com/networkservicemesh/sdk/pull/1353/checks?check_run_id=8351758816 In short, you can just do something simple like |
We were getting a *lot* of log chaff at TRACE level during normal operation because gRPC returns a "context canceled" error periodically but it's not really an error for us because we immediately loop around again. This commit uses the gRPC status.Code() method to identify these non-errors. It also uses errors.Is() instead of == to compare error objects. This handles wrapped errors. https://pkg.go.dev/google.golang.org/grpc/status#Code https://github.com/golang/go/wiki/ErrorValueFAQ#how-should-i-change-my-error-handling-code-to-work-with-the-new-features Signed-off-by: Toby Cabot <toby@acnodal.io>
ghost
force-pushed
the
dont-trace-cancels
branch
from
0dfc21e to
5e5cfb5
Compare
|
Ah, I get it. Unfortunately confusing git terminology! I was signing the commit (-S) but it sounds like you want me to signoff (-s) the commit. It should be all set now, I did both. |
|
@acnodal-tc It's a useful fix. Thanks! |
nsmbot
pushed a commit
to networkservicemesh/cmd-cluster-info-k8s
that referenced
this pull request
Sep 14, 2022
…k@main PR link: networkservicemesh/sdk#1353 Commit: 97e00ec Author: toby cabot Date: 2022-09-14 19:33:40 -0400 Message: - Don't trace gRPC "Canceled" errors (#1353) We were getting a *lot* of log chaff at TRACE level during normal operation because gRPC returns a "context canceled" error periodically but it's not really an error for us because we immediately loop around again. This commit uses the gRPC status.Code() method to identify these non-errors. It also uses errors.Is() instead of == to compare error objects. This handles wrapped errors. https://pkg.go.dev/google.golang.org/grpc/status#Code https://github.com/golang/go/wiki/ErrorValueFAQ#how-should-i-change-my-error-handling-code-to-work-with-the-new-features Signed-off-by: Toby Cabot <toby@acnodal.io> Signed-off-by: Toby Cabot <toby@acnodal.io> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Sep 14, 2022
…k@main PR link: networkservicemesh/sdk#1353 Commit: 97e00ec Author: toby cabot Date: 2022-09-14 19:33:40 -0400 Message: - Don't trace gRPC "Canceled" errors (#1353) We were getting a *lot* of log chaff at TRACE level during normal operation because gRPC returns a "context canceled" error periodically but it's not really an error for us because we immediately loop around again. This commit uses the gRPC status.Code() method to identify these non-errors. It also uses errors.Is() instead of == to compare error objects. This handles wrapped errors. https://pkg.go.dev/google.golang.org/grpc/status#Code https://github.com/golang/go/wiki/ErrorValueFAQ#how-should-i-change-my-error-handling-code-to-work-with-the-new-features Signed-off-by: Toby Cabot <toby@acnodal.io> Signed-off-by: Toby Cabot <toby@acnodal.io> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Sep 14, 2022
…k@main PR link: networkservicemesh/sdk#1353 Commit: 97e00ec Author: toby cabot Date: 2022-09-14 19:33:40 -0400 Message: - Don't trace gRPC "Canceled" errors (#1353) We were getting a *lot* of log chaff at TRACE level during normal operation because gRPC returns a "context canceled" error periodically but it's not really an error for us because we immediately loop around again. This commit uses the gRPC status.Code() method to identify these non-errors. It also uses errors.Is() instead of == to compare error objects. This handles wrapped errors. https://pkg.go.dev/google.golang.org/grpc/status#Code https://github.com/golang/go/wiki/ErrorValueFAQ#how-should-i-change-my-error-handling-code-to-work-with-the-new-features Signed-off-by: Toby Cabot <toby@acnodal.io> Signed-off-by: Toby Cabot <toby@acnodal.io> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Sep 14, 2022
…k@main PR link: networkservicemesh/sdk#1353 Commit: 97e00ec Author: toby cabot Date: 2022-09-14 19:33:40 -0400 Message: - Don't trace gRPC "Canceled" errors (#1353) We were getting a *lot* of log chaff at TRACE level during normal operation because gRPC returns a "context canceled" error periodically but it's not really an error for us because we immediately loop around again. This commit uses the gRPC status.Code() method to identify these non-errors. It also uses errors.Is() instead of == to compare error objects. This handles wrapped errors. https://pkg.go.dev/google.golang.org/grpc/status#Code https://github.com/golang/go/wiki/ErrorValueFAQ#how-should-i-change-my-error-handling-code-to-work-with-the-new-features Signed-off-by: Toby Cabot <toby@acnodal.io> Signed-off-by: Toby Cabot <toby@acnodal.io> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Sep 14, 2022
…k@main PR link: networkservicemesh/sdk#1353 Commit: 97e00ec Author: toby cabot Date: 2022-09-14 19:33:40 -0400 Message: - Don't trace gRPC "Canceled" errors (#1353) We were getting a *lot* of log chaff at TRACE level during normal operation because gRPC returns a "context canceled" error periodically but it's not really an error for us because we immediately loop around again. This commit uses the gRPC status.Code() method to identify these non-errors. It also uses errors.Is() instead of == to compare error objects. This handles wrapped errors. https://pkg.go.dev/google.golang.org/grpc/status#Code https://github.com/golang/go/wiki/ErrorValueFAQ#how-should-i-change-my-error-handling-code-to-work-with-the-new-features Signed-off-by: Toby Cabot <toby@acnodal.io> Signed-off-by: Toby Cabot <toby@acnodal.io> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-ipam-vl3
that referenced
this pull request
Sep 14, 2022
…k@main PR link: networkservicemesh/sdk#1353 Commit: 97e00ec Author: toby cabot Date: 2022-09-14 19:33:40 -0400 Message: - Don't trace gRPC "Canceled" errors (#1353) We were getting a *lot* of log chaff at TRACE level during normal operation because gRPC returns a "context canceled" error periodically but it's not really an error for us because we immediately loop around again. This commit uses the gRPC status.Code() method to identify these non-errors. It also uses errors.Is() instead of == to compare error objects. This handles wrapped errors. https://pkg.go.dev/google.golang.org/grpc/status#Code https://github.com/golang/go/wiki/ErrorValueFAQ#how-should-i-change-my-error-handling-code-to-work-with-the-new-features Signed-off-by: Toby Cabot <toby@acnodal.io> Signed-off-by: Toby Cabot <toby@acnodal.io> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
Sep 14, 2022
…k@main PR link: networkservicemesh/sdk#1353 Commit: 97e00ec Author: toby cabot Date: 2022-09-14 19:33:40 -0400 Message: - Don't trace gRPC "Canceled" errors (#1353) We were getting a *lot* of log chaff at TRACE level during normal operation because gRPC returns a "context canceled" error periodically but it's not really an error for us because we immediately loop around again. This commit uses the gRPC status.Code() method to identify these non-errors. It also uses errors.Is() instead of == to compare error objects. This handles wrapped errors. https://pkg.go.dev/google.golang.org/grpc/status#Code https://github.com/golang/go/wiki/ErrorValueFAQ#how-should-i-change-my-error-handling-code-to-work-with-the-new-features Signed-off-by: Toby Cabot <toby@acnodal.io> Signed-off-by: Toby Cabot <toby@acnodal.io> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
Sep 14, 2022
…k@main PR link: networkservicemesh/sdk#1353 Commit: 97e00ec Author: toby cabot Date: 2022-09-14 19:33:40 -0400 Message: - Don't trace gRPC "Canceled" errors (#1353) We were getting a *lot* of log chaff at TRACE level during normal operation because gRPC returns a "context canceled" error periodically but it's not really an error for us because we immediately loop around again. This commit uses the gRPC status.Code() method to identify these non-errors. It also uses errors.Is() instead of == to compare error objects. This handles wrapped errors. https://pkg.go.dev/google.golang.org/grpc/status#Code https://github.com/golang/go/wiki/ErrorValueFAQ#how-should-i-change-my-error-handling-code-to-work-with-the-new-features Signed-off-by: Toby Cabot <toby@acnodal.io> Signed-off-by: Toby Cabot <toby@acnodal.io> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-map-ip-k8s
that referenced
this pull request
Sep 14, 2022
…k@main PR link: networkservicemesh/sdk#1353 Commit: 97e00ec Author: toby cabot Date: 2022-09-14 19:33:40 -0400 Message: - Don't trace gRPC "Canceled" errors (#1353) We were getting a *lot* of log chaff at TRACE level during normal operation because gRPC returns a "context canceled" error periodically but it's not really an error for us because we immediately loop around again. This commit uses the gRPC status.Code() method to identify these non-errors. It also uses errors.Is() instead of == to compare error objects. This handles wrapped errors. https://pkg.go.dev/google.golang.org/grpc/status#Code https://github.com/golang/go/wiki/ErrorValueFAQ#how-should-i-change-my-error-handling-code-to-work-with-the-new-features Signed-off-by: Toby Cabot <toby@acnodal.io> Signed-off-by: Toby Cabot <toby@acnodal.io> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Sep 14, 2022
…k@main PR link: networkservicemesh/sdk#1353 Commit: 97e00ec Author: toby cabot Date: 2022-09-14 19:33:40 -0400 Message: - Don't trace gRPC "Canceled" errors (#1353) We were getting a *lot* of log chaff at TRACE level during normal operation because gRPC returns a "context canceled" error periodically but it's not really an error for us because we immediately loop around again. This commit uses the gRPC status.Code() method to identify these non-errors. It also uses errors.Is() instead of == to compare error objects. This handles wrapped errors. https://pkg.go.dev/google.golang.org/grpc/status#Code https://github.com/golang/go/wiki/ErrorValueFAQ#how-should-i-change-my-error-handling-code-to-work-with-the-new-features Signed-off-by: Toby Cabot <toby@acnodal.io> Signed-off-by: Toby Cabot <toby@acnodal.io> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Sep 14, 2022
…k@main PR link: networkservicemesh/sdk#1353 Commit: 97e00ec Author: toby cabot Date: 2022-09-14 19:33:40 -0400 Message: - Don't trace gRPC "Canceled" errors (#1353) We were getting a *lot* of log chaff at TRACE level during normal operation because gRPC returns a "context canceled" error periodically but it's not really an error for us because we immediately loop around again. This commit uses the gRPC status.Code() method to identify these non-errors. It also uses errors.Is() instead of == to compare error objects. This handles wrapped errors. https://pkg.go.dev/google.golang.org/grpc/status#Code https://github.com/golang/go/wiki/ErrorValueFAQ#how-should-i-change-my-error-handling-code-to-work-with-the-new-features Signed-off-by: Toby Cabot <toby@acnodal.io> Signed-off-by: Toby Cabot <toby@acnodal.io> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Sep 14, 2022
…k@main PR link: networkservicemesh/sdk#1353 Commit: 97e00ec Author: toby cabot Date: 2022-09-14 19:33:40 -0400 Message: - Don't trace gRPC "Canceled" errors (#1353) We were getting a *lot* of log chaff at TRACE level during normal operation because gRPC returns a "context canceled" error periodically but it's not really an error for us because we immediately loop around again. This commit uses the gRPC status.Code() method to identify these non-errors. It also uses errors.Is() instead of == to compare error objects. This handles wrapped errors. https://pkg.go.dev/google.golang.org/grpc/status#Code https://github.com/golang/go/wiki/ErrorValueFAQ#how-should-i-change-my-error-handling-code-to-work-with-the-new-features Signed-off-by: Toby Cabot <toby@acnodal.io> Signed-off-by: Toby Cabot <toby@acnodal.io> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
|
Thank you for your patience in helping me get the patch in shape to merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We were getting a lot of log chaff at TRACE level during normal operation because gRPC returns a "context canceled" error periodically but it's not really an error for us because we immediately loop around again.
This commit uses the gRPC status.Code() method to identify these non-errors. It also uses errors.Is() instead of == to compare error objects. This handles wrapped errors.
https://pkg.go.dev/google.golang.org/grpc/status#Code
https://github.com/golang/go/wiki/ErrorValueFAQ#how-should-i-change-my-error-handling-code-to-work-with-the-new-features
Issue link
#1068
How Has This Been Tested?
Deploy cmd-nse-icmp-responder, see periodic "context cancelled" errors, deploy build with patched SDK, verify that errors aren't present.
Types of changes
Only relevant when running at TRACE log level.