Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[qfix] Fix empty path panic in Registry Authorize chain elements #1403

Merged
merged 1 commit into from
Dec 19, 2022
Merged

[qfix] Fix empty path panic in Registry Authorize chain elements #1403

merged 1 commit into from
Dec 19, 2022

Conversation

NikitaSkrynnik
Copy link
Contributor

Signed-off-by: Nikita Skrynnik nikita.skrynnik@xored.com

Description

Issue link

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

@NikitaSkrynnik
[qfix] fix empty path panic in Registry Authorize chain elements
607fc34 
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
denis-tingaikin
denis-tingaikin approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code related to registry opa definitely requires a refactor to make things clear and stable.

Will refactor this after the release v1.7.0.

For now, am merging this.

@denis-tingaikin denis-tingaikin merged commit beec79b into networkservicemesh:main Dec 19, 2022
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this pull request Dec 19, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
73c6d94 
…k@main

PR link: networkservicemesh/sdk#1403

Commit: beec79b
Author: Nikita Skrynnik
Date: 2022-12-20 02:26:52 +1100
Message:
  - [qfix] fix empty path panic in Registry Authorize chain elements (#1403)
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Dec 19, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
f003526 
…k@main

PR link: networkservicemesh/sdk#1403

Commit: beec79b
Author: Nikita Skrynnik
Date: 2022-12-20 02:26:52 +1100
Message:
  - [qfix] fix empty path panic in Registry Authorize chain elements (#1403)
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Dec 19, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
48d8c74 
…k@main

PR link: networkservicemesh/sdk#1403

Commit: beec79b
Author: Nikita Skrynnik
Date: 2022-12-20 02:26:52 +1100
Message:
  - [qfix] fix empty path panic in Registry Authorize chain elements (#1403)
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Dec 19, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
d3980f6 
…k@main

PR link: networkservicemesh/sdk#1403

Commit: beec79b
Author: Nikita Skrynnik
Date: 2022-12-20 02:26:52 +1100
Message:
  - [qfix] fix empty path panic in Registry Authorize chain elements (#1403)
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Dec 19, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
cbf7ebb 
…k@main

PR link: networkservicemesh/sdk#1403

Commit: beec79b
Author: Nikita Skrynnik
Date: 2022-12-20 02:26:52 +1100
Message:
  - [qfix] fix empty path panic in Registry Authorize chain elements (#1403)
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Dec 19, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
8cc6bbe 
…k@main

PR link: networkservicemesh/sdk#1403

Commit: beec79b
Author: Nikita Skrynnik
Date: 2022-12-20 02:26:52 +1100
Message:
  - [qfix] fix empty path panic in Registry Authorize chain elements (#1403)
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Dec 19, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
d2cfa87 
…k@main

PR link: networkservicemesh/sdk#1403

Commit: beec79b
Author: Nikita Skrynnik
Date: 2022-12-20 02:26:52 +1100
Message:
  - [qfix] fix empty path panic in Registry Authorize chain elements (#1403)
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Dec 19, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
a97f404 
…k@main

PR link: networkservicemesh/sdk#1403

Commit: beec79b
Author: Nikita Skrynnik
Date: 2022-12-20 02:26:52 +1100
Message:
  - [qfix] fix empty path panic in Registry Authorize chain elements (#1403)
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Dec 19, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
9a7a736 
…k@main

PR link: networkservicemesh/sdk#1403

Commit: beec79b
Author: Nikita Skrynnik
Date: 2022-12-20 02:26:52 +1100
Message:
  - [qfix] fix empty path panic in Registry Authorize chain elements (#1403)
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Dec 19, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
81c1ab8 
…k@main

PR link: networkservicemesh/sdk#1403

Commit: beec79b
Author: Nikita Skrynnik
Date: 2022-12-20 02:26:52 +1100
Message:
  - [qfix] fix empty path panic in Registry Authorize chain elements (#1403)
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Dec 19, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
8298bb0 
…k@main

PR link: networkservicemesh/sdk#1403

Commit: beec79b
Author: Nikita Skrynnik
Date: 2022-12-20 02:26:52 +1100
Message:
  - [qfix] fix empty path panic in Registry Authorize chain elements (#1403)
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Dec 19, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
423485f 
…k@main

PR link: networkservicemesh/sdk#1403

Commit: beec79b
Author: Nikita Skrynnik
Date: 2022-12-20 02:26:52 +1100
Message:
  - [qfix] fix empty path panic in Registry Authorize chain elements (#1403)
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Dec 19, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
30da505 
…k@main

PR link: networkservicemesh/sdk#1403

Commit: beec79b
Author: Nikita Skrynnik
Date: 2022-12-20 02:26:52 +1100
Message:
  - [qfix] fix empty path panic in Registry Authorize chain elements (#1403)
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Dec 19, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Dec 19, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
a585048 
…k@main

PR link: networkservicemesh/sdk#1403

Commit: beec79b
Author: Nikita Skrynnik
Date: 2022-12-20 02:26:52 +1100
Message:
  - [qfix] fix empty path panic in Registry Authorize chain elements (#1403)
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Dec 19, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
36e8526 
…k@main

PR link: networkservicemesh/sdk#1403

Commit: beec79b
Author: Nikita Skrynnik
Date: 2022-12-20 02:26:52 +1100
Message:
  - [qfix] fix empty path panic in Registry Authorize chain elements (#1403)
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Dec 19, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
d54937e 
…k@main

PR link: networkservicemesh/sdk#1403

Commit: beec79b
Author: Nikita Skrynnik
Date: 2022-12-20 02:26:52 +1100
Message:
  - [qfix] fix empty path panic in Registry Authorize chain elements (#1403)
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@nsmbot nsmbot mentioned this pull request Dec 19, 2022
Merged
This was referenced Dec 19, 2022
Merged
Merged
@NikitaSkrynnik NikitaSkrynnik deleted the fix-panic branch July 13, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NikitaSkrynnik @denis-tingaikin