Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vl3 dns configurations #1460

Merged
merged 1 commit into from
May 16, 2023
Merged

Fix vl3 dns configurations #1460

merged 1 commit into from
May 16, 2023

Conversation

glazychev-art
Copy link
Contributor

@glazychev-art glazychev-art commented May 11, 2023 •
edited
Loading

Description

Main changes:

  1. NSC shouldn't add private resolv.conf fields to Request in dnsContextClient
  2. vl3-dns should add search domains for the Connection. If DNS record is "target.d1.d2.d3." - it adds ["d1.d2.d3", "d2.d3", "d3"]

Issue link

#1426

How Has This Been Tested?

  • Fixed unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionality
  • Documentation
  • Refactoring
  • CI

@codecov
Copy link

codecov bot commented May 11, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@6fa2f68). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1460   +/-   ##
=======================================
  Coverage        ?   70.23%           
=======================================
  Files           ?      242           
  Lines           ?    11006           
  Branches        ?        0           
=======================================
  Hits            ?     7730           
  Misses          ?     2778           
  Partials        ?      498

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@glazychev-art glazychev-art force-pushed the vl3_dns_fix_searchdomain branch 5 times, most recently from 6a6910a to 5297b97 Compare May 11, 2023 10:16
@glazychev-art
Fix vl3 dns configurations
b32916a 
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
@glazychev-art glazychev-art marked this pull request as ready for review May 11, 2023 10:43
@denis-tingaikin denis-tingaikin merged commit 309d5a6 into networkservicemesh:main May 16, 2023
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request May 16, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
77799a4 
…k@main

PR link: networkservicemesh/sdk#1460

Commit: 309d5a6
Author: Artem Glazychev
Date: 2023-05-16 21:39:56 +0700
Message:
  - Fix vl3 dns configurations (#1460)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request May 16, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
612fe73 
…k@main

PR link: networkservicemesh/sdk#1460

Commit: 309d5a6
Author: Artem Glazychev
Date: 2023-05-16 21:39:56 +0700
Message:
  - Fix vl3 dns configurations (#1460)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request May 16, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
86714c6 
…k@main

PR link: networkservicemesh/sdk#1460

Commit: 309d5a6
Author: Artem Glazychev
Date: 2023-05-16 21:39:56 +0700
Message:
  - Fix vl3 dns configurations (#1460)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request May 16, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
8b24ac9 
…k@main

PR link: networkservicemesh/sdk#1460

Commit: 309d5a6
Author: Artem Glazychev
Date: 2023-05-16 21:39:56 +0700
Message:
  - Fix vl3 dns configurations (#1460)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this pull request May 16, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
1e3a9ab 
…k@main

PR link: networkservicemesh/sdk#1460

Commit: 309d5a6
Author: Artem Glazychev
Date: 2023-05-16 21:39:56 +0700
Message:
  - Fix vl3 dns configurations (#1460)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request May 16, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
c4de60b 
…k@main

PR link: networkservicemesh/sdk#1460

Commit: 309d5a6
Author: Artem Glazychev
Date: 2023-05-16 21:39:56 +0700
Message:
  - Fix vl3 dns configurations (#1460)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request May 16, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
36c8b24 
…k@main

PR link: networkservicemesh/sdk#1460

Commit: 309d5a6
Author: Artem Glazychev
Date: 2023-05-16 21:39:56 +0700
Message:
  - Fix vl3 dns configurations (#1460)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request May 16, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
cbf437e 
…k@main

PR link: networkservicemesh/sdk#1460

Commit: 309d5a6
Author: Artem Glazychev
Date: 2023-05-16 21:39:56 +0700
Message:
  - Fix vl3 dns configurations (#1460)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request May 16, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
6db5494 
…k@main

PR link: networkservicemesh/sdk#1460

Commit: 309d5a6
Author: Artem Glazychev
Date: 2023-05-16 21:39:56 +0700
Message:
  - Fix vl3 dns configurations (#1460)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request May 16, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
1abc959 
…k@main

PR link: networkservicemesh/sdk#1460

Commit: 309d5a6
Author: Artem Glazychev
Date: 2023-05-16 21:39:56 +0700
Message:
  - Fix vl3 dns configurations (#1460)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request May 16, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
bd33551 
…k@main

PR link: networkservicemesh/sdk#1460

Commit: 309d5a6
Author: Artem Glazychev
Date: 2023-05-16 21:39:56 +0700
Message:
  - Fix vl3 dns configurations (#1460)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request May 16, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
84bebae 
…k@main

PR link: networkservicemesh/sdk#1460

Commit: 309d5a6
Author: Artem Glazychev
Date: 2023-05-16 21:39:56 +0700
Message:
  - Fix vl3 dns configurations (#1460)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request May 16, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
4f4eef0 
…k@main

PR link: networkservicemesh/sdk#1460

Commit: 309d5a6
Author: Artem Glazychev
Date: 2023-05-16 21:39:56 +0700
Message:
  - Fix vl3 dns configurations (#1460)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced May 16, 2023
Merged
Merged
This was referenced May 16, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-uzlov d-uzlov d-uzlov approved these changes

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

@NikitaSkrynnik NikitaSkrynnik Awaiting requested review from NikitaSkrynnik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glazychev-art @d-uzlov @denis-tingaikin