Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cleanup when connection state is RESELECT_REQUESTED (using connection monitor server) #1469

Closed
wants to merge 8 commits into from

Conversation

d-uzlov
Copy link
Contributor

@d-uzlov d-uzlov commented Jun 16, 2023

Description

Add reselectcleanup element that calls Close when reselect is requested for already existing connection.

Issue link

#1454

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionality
  • Documentation
  • Refactoring
  • CI

@d-uzlov d-uzlov force-pushed the 1454-reselectcleanup branch from 5bd878d to 1387a56 Compare June 16, 2023 09:57
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@63043b2). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1469   +/-   ##
=======================================
  Coverage        ?   70.22%           
=======================================
  Files           ?      248           
  Lines           ?    11184           
  Branches        ?        0           
=======================================
  Hits            ?     7854           
  Misses          ?     2829           
  Partials        ?      501           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@d-uzlov d-uzlov force-pushed the 1454-reselectcleanup branch from 895c836 to 1dad932 Compare June 19, 2023 06:55
@d-uzlov d-uzlov changed the title Add cleanup when connection state is RESELECT_REQUESTED Add cleanup when connection state is RESELECT_REQUESTED (using connection monitor server) Jun 19, 2023
d-uzlov added 4 commits June 20, 2023 18:36
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
@d-uzlov d-uzlov force-pushed the 1454-reselectcleanup branch from 1dad932 to fdd9495 Compare June 20, 2023 11:56
d-uzlov added 3 commits June 20, 2023 19:03
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
@d-uzlov d-uzlov force-pushed the 1454-reselectcleanup branch 3 times, most recently from 22d3ab1 to 04f8683 Compare June 20, 2023 12:40
monitor server can now provide connections locally

Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
@d-uzlov d-uzlov force-pushed the 1454-reselectcleanup branch from 04f8683 to bdf85c5 Compare June 20, 2023 12:58
@d-uzlov d-uzlov closed this Jun 21, 2023
@d-uzlov d-uzlov deleted the 1454-reselectcleanup branch June 21, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant