Enable logs from chain elements regardless of EnableTracing
#1475
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently all logs from chain elements are enabled or disabled by
log.EnableTracing(true)
call.cmd
apps dolog.EnableTracing(level == logrus.TraceLevel)
, which means that we either haveTRACE
logs, or we don't have any logs at all.This PR decouples logs from tracing:
logLevel == TRACE
andlog.EnableTracing(true)
, then we will get current behaviorlogLevel == TRACE
andlog.EnableTracing(false)
, then we will get current behavior withoutrequest=
,request-diff=
,request-response=
log entries (because calculating diffs is expensive)logLevel == DEBUG
andlog.EnableTracing(false)
then we will only getDEBUG
level log and above, but we will still get them, from all chain elementsExample logs from forwarder with `DEBUG` log level
Issue link
How Has This Been Tested?
Types of changes