Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close with eventFactory from begin.Server in case of RESELECT_REQUESTED #1480

Merged

Conversation

glazychev-art
Copy link
Contributor

@glazychev-art glazychev-art commented Jul 4, 2023

Description

Issue link

#1454

How Has This Been Tested?

  • Fixed unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionality
  • Documentation
  • Refactoring
  • CI

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@0ba94ea). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head df5978d differs from pull request most recent head e5ee6cc. Consider uploading reports for the commit e5ee6cc to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1480   +/-   ##
=======================================
  Coverage        ?   70.31%           
=======================================
  Files           ?      248           
  Lines           ?    11196           
  Branches        ?        0           
=======================================
  Hits            ?     7872           
  Misses          ?     2822           
  Partials        ?      502           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
@glazychev-art glazychev-art marked this pull request as ready for review July 4, 2023 09:24
@denis-tingaikin denis-tingaikin merged commit f349173 into networkservicemesh:main Jul 4, 2023
nsmbot pushed a commit to networkservicemesh/cmd-csi-driver that referenced this pull request Jul 4, 2023
…k@main

PR link: networkservicemesh/sdk#1480

Commit: f349173
Author: Artem Glazychev
Date: 2023-07-04 16:41:11 +0700
Message:
  - Close with eventFactory from begin.Server in case of RESELECT_REQUESTED (#1480)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this pull request Jul 4, 2023
…k@main

PR link: networkservicemesh/sdk#1480

Commit: f349173
Author: Artem Glazychev
Date: 2023-07-04 16:41:11 +0700
Message:
  - Close with eventFactory from begin.Server in case of RESELECT_REQUESTED (#1480)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Jul 4, 2023
…k@main

PR link: networkservicemesh/sdk#1480

Commit: f349173
Author: Artem Glazychev
Date: 2023-07-04 16:41:11 +0700
Message:
  - Close with eventFactory from begin.Server in case of RESELECT_REQUESTED (#1480)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Jul 4, 2023
…k@main

PR link: networkservicemesh/sdk#1480

Commit: f349173
Author: Artem Glazychev
Date: 2023-07-04 16:41:11 +0700
Message:
  - Close with eventFactory from begin.Server in case of RESELECT_REQUESTED (#1480)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Jul 4, 2023
…k@main

PR link: networkservicemesh/sdk#1480

Commit: f349173
Author: Artem Glazychev
Date: 2023-07-04 16:41:11 +0700
Message:
  - Close with eventFactory from begin.Server in case of RESELECT_REQUESTED (#1480)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Jul 4, 2023
…k@main

PR link: networkservicemesh/sdk#1480

Commit: f349173
Author: Artem Glazychev
Date: 2023-07-04 16:41:11 +0700
Message:
  - Close with eventFactory from begin.Server in case of RESELECT_REQUESTED (#1480)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Jul 4, 2023
…k@main

PR link: networkservicemesh/sdk#1480

Commit: f349173
Author: Artem Glazychev
Date: 2023-07-04 16:41:11 +0700
Message:
  - Close with eventFactory from begin.Server in case of RESELECT_REQUESTED (#1480)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Jul 4, 2023
…k@main

PR link: networkservicemesh/sdk#1480

Commit: f349173
Author: Artem Glazychev
Date: 2023-07-04 16:41:11 +0700
Message:
  - Close with eventFactory from begin.Server in case of RESELECT_REQUESTED (#1480)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Jul 4, 2023
…k@main

PR link: networkservicemesh/sdk#1480

Commit: f349173
Author: Artem Glazychev
Date: 2023-07-04 16:41:11 +0700
Message:
  - Close with eventFactory from begin.Server in case of RESELECT_REQUESTED (#1480)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Jul 4, 2023
…k@main

PR link: networkservicemesh/sdk#1480

Commit: f349173
Author: Artem Glazychev
Date: 2023-07-04 16:41:11 +0700
Message:
  - Close with eventFactory from begin.Server in case of RESELECT_REQUESTED (#1480)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Jul 4, 2023
…k@main

PR link: networkservicemesh/sdk#1480

Commit: f349173
Author: Artem Glazychev
Date: 2023-07-04 16:41:11 +0700
Message:
  - Close with eventFactory from begin.Server in case of RESELECT_REQUESTED (#1480)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Jul 4, 2023
…k@main

PR link: networkservicemesh/sdk#1480

Commit: f349173
Author: Artem Glazychev
Date: 2023-07-04 16:41:11 +0700
Message:
  - Close with eventFactory from begin.Server in case of RESELECT_REQUESTED (#1480)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Jul 4, 2023
…k@main

PR link: networkservicemesh/sdk#1480

Commit: f349173
Author: Artem Glazychev
Date: 2023-07-04 16:41:11 +0700
Message:
  - Close with eventFactory from begin.Server in case of RESELECT_REQUESTED (#1480)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Jul 4, 2023
…k@main

PR link: networkservicemesh/sdk#1480

Commit: f349173
Author: Artem Glazychev
Date: 2023-07-04 16:41:11 +0700
Message:
  - Close with eventFactory from begin.Server in case of RESELECT_REQUESTED (#1480)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants