qfix: Do not reset IPContext configuration on the reselect #1582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denis-tingaikin
requested review from
edwarnicke,
LionelJouin and
glazychev-art
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
denis-tingaikin
force-pushed
the
allow-to-use-previous-settings
branch
from
f2c3abc to
8cd752c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1582 +/- ##
=======================================
Coverage ? 67.30%
=======================================
Files ? 261
Lines ? 12381
Branches ? 0
=======================================
Hits ? 8333
Misses ? 3524
Partials ? 524 ☔ View full report in Codecov by Sentry. |
denis-tingaikin
force-pushed
the
allow-to-use-previous-settings
branch
from
1cf1f82 to
de39a26
Compare
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
denis-tingaikin
force-pushed
the
allow-to-use-previous-settings
branch
from
de39a26 to
e690672
Compare
LionelJouin
approved these changes
Feb 1, 2024
| ) | ||
| } | ||
|
|
||
| func (n *strictIPAMServer) areAddressesValid(addresses []string) bool { |
There was a problem hiding this comment.
It depends on each NSE and IPAM needs, but here nothing prevent a NSC to request the connection with an IP that is used by another connection.
There was a problem hiding this comment.
Yes, it's right. With this patch, we're shifting the responsibility of managing IP contexts to NSEs. I also added a new IPAM wrapper chain element that can be used for clearing unepected addresses (if someone will need this functionality in the future). At this moment, it's used only in unit tests, but it can also be used for common cases, for example, as described in the original issue: networkservicemesh/deployments-k8s#9888 ;)
glazychev-art
approved these changes
Feb 5, 2024
nsmbot
pushed a commit
to networkservicemesh/cmd-dashboard-backend
that referenced
this pull request
Feb 5, 2024
…k@main PR link: networkservicemesh/sdk#1582 Commit: f37b863 Author: Denis Tingaikin Date: 2024-02-05 14:03:52 +0300 Message: - qfix: Do not reset IPContext configuration on the reselect (#1582) * do not reset IPContext configuration on the reselect Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> * fix linter issues Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-map-ip-k8s
that referenced
this pull request
Feb 5, 2024
…k@main PR link: networkservicemesh/sdk#1582 Commit: f37b863 Author: Denis Tingaikin Date: 2024-02-05 14:03:52 +0300 Message: - qfix: Do not reset IPContext configuration on the reselect (#1582) * do not reset IPContext configuration on the reselect Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> * fix linter issues Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-ipam-vl3
that referenced
this pull request
Feb 5, 2024
…k@main PR link: networkservicemesh/sdk#1582 Commit: f37b863 Author: Denis Tingaikin Date: 2024-02-05 14:03:52 +0300 Message: - qfix: Do not reset IPContext configuration on the reselect (#1582) * do not reset IPContext configuration on the reselect Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> * fix linter issues Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Feb 5, 2024
…k@main PR link: networkservicemesh/sdk#1582 Commit: f37b863 Author: Denis Tingaikin Date: 2024-02-05 14:03:52 +0300 Message: - qfix: Do not reset IPContext configuration on the reselect (#1582) * do not reset IPContext configuration on the reselect Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> * fix linter issues Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-cluster-info-k8s
that referenced
this pull request
Feb 5, 2024
…k@main PR link: networkservicemesh/sdk#1582 Commit: f37b863 Author: Denis Tingaikin Date: 2024-02-05 14:03:52 +0300 Message: - qfix: Do not reset IPContext configuration on the reselect (#1582) * do not reset IPContext configuration on the reselect Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> * fix linter issues Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-csi-driver
that referenced
this pull request
Feb 5, 2024
…k@main PR link: networkservicemesh/sdk#1582 Commit: f37b863 Author: Denis Tingaikin Date: 2024-02-05 14:03:52 +0300 Message: - qfix: Do not reset IPContext configuration on the reselect (#1582) * do not reset IPContext configuration on the reselect Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> * fix linter issues Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Feb 5, 2024
…k@main PR link: networkservicemesh/sdk#1582 Commit: f37b863 Author: Denis Tingaikin Date: 2024-02-05 14:03:52 +0300 Message: - qfix: Do not reset IPContext configuration on the reselect (#1582) * do not reset IPContext configuration on the reselect Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> * fix linter issues Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Feb 5, 2024
…k@main PR link: networkservicemesh/sdk#1582 Commit: f37b863 Author: Denis Tingaikin Date: 2024-02-05 14:03:52 +0300 Message: - qfix: Do not reset IPContext configuration on the reselect (#1582) * do not reset IPContext configuration on the reselect Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> * fix linter issues Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Feb 5, 2024
…k@main PR link: networkservicemesh/sdk#1582 Commit: f37b863 Author: Denis Tingaikin Date: 2024-02-05 14:03:52 +0300 Message: - qfix: Do not reset IPContext configuration on the reselect (#1582) * do not reset IPContext configuration on the reselect Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> * fix linter issues Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Feb 5, 2024
…k@main PR link: networkservicemesh/sdk#1582 Commit: f37b863 Author: Denis Tingaikin Date: 2024-02-05 14:03:52 +0300 Message: - qfix: Do not reset IPContext configuration on the reselect (#1582) * do not reset IPContext configuration on the reselect Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> * fix linter issues Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Feb 5, 2024
…k@main PR link: networkservicemesh/sdk#1582 Commit: f37b863 Author: Denis Tingaikin Date: 2024-02-05 14:03:52 +0300 Message: - qfix: Do not reset IPContext configuration on the reselect (#1582) * do not reset IPContext configuration on the reselect Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> * fix linter issues Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
Feb 5, 2024
…k@main PR link: networkservicemesh/sdk#1582 Commit: f37b863 Author: Denis Tingaikin Date: 2024-02-05 14:03:52 +0300 Message: - qfix: Do not reset IPContext configuration on the reselect (#1582) * do not reset IPContext configuration on the reselect Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> * fix linter issues Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Feb 5, 2024
…k@main PR link: networkservicemesh/sdk#1582 Commit: f37b863 Author: Denis Tingaikin Date: 2024-02-05 14:03:52 +0300 Message: - qfix: Do not reset IPContext configuration on the reselect (#1582) * do not reset IPContext configuration on the reselect Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> * fix linter issues Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
Feb 5, 2024
…k@main PR link: networkservicemesh/sdk#1582 Commit: f37b863 Author: Denis Tingaikin Date: 2024-02-05 14:03:52 +0300 Message: - qfix: Do not reset IPContext configuration on the reselect (#1582) * do not reset IPContext configuration on the reselect Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> * fix linter issues Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Feb 5, 2024
…k@main PR link: networkservicemesh/sdk#1582 Commit: f37b863 Author: Denis Tingaikin Date: 2024-02-05 14:03:52 +0300 Message: - qfix: Do not reset IPContext configuration on the reselect (#1582) * do not reset IPContext configuration on the reselect Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> * fix linter issues Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Feb 5, 2024
This was referenced Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As we'd discussed on the latest meeting, we decided not to clear the IP context on the NSC side. See at networkservicemesh/deployments-k8s#9888 (comment)
Issue link
Closes networkservicemesh/deployments-k8s#9888
How Has This Been Tested?
Types of changes