Include excludedPrefixes when checking if vl3.IPAM contains an ip net #1602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
… addr Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
NikitaSkrynnik
force-pushed
the
fix-ipam-check
branch
from
fdc04f9
to
09e4c10
Compare
Comment on lines
+189
to
+193
| for k := range p.excludedPrefixes { | ||
| if k == ipNet { | ||
| return true | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| for k := range p.excludedPrefixes { | |
| if k == ipNet { | |
| return true | |
| } | |
| } | |
| _, ok := excludedPrefixes[ipNet] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
vl3.IPAM has
excludedPrefixesfield. When callingIPAM.ContainsNetString()we also should checkexcludedPrefixesIssue link
networkservicemesh/cmd-nse-vl3-vpp#289
How Has This Been Tested?
Types of changes