-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return error in case no network service is defined #454
Merged
denis-tingaikin
merged 1 commit into
networkservicemesh:master
from
haiodo:fix-missing-service
Sep 9, 2020
Merged
Return error in case no network service is defined #454
denis-tingaikin
merged 1 commit into
networkservicemesh:master
from
haiodo:fix-missing-service
Sep 9, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denis-tingaikin
requested changes
Sep 9, 2020
Return error in case no network service is defined Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
denis-tingaikin
approved these changes
Sep 9, 2020
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Sep 9, 2020
…k@master networkservicemesh/sdk#454 networkservicemesh/sdk PR link: networkservicemesh/sdk#454 networkservicemesh/sdk commit message: commit c5c4ed12d18a9d35b624ef65f1aeec76072310b5 Author: Andrey Sobolev <haiodo@users.noreply.github.com> Date: Wed Sep 9 15:56:30 2020 +0700 Return error in case no network service is defined (#454) Return error in case no network service is defined Signed-off-by: Andrey Sobolev <haiodo@gmail.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Sep 9, 2020
…k@master networkservicemesh/sdk#454 networkservicemesh/sdk PR link: networkservicemesh/sdk#454 networkservicemesh/sdk commit message: commit c5c4ed12d18a9d35b624ef65f1aeec76072310b5 Author: Andrey Sobolev <haiodo@users.noreply.github.com> Date: Wed Sep 9 15:56:30 2020 +0700 Return error in case no network service is defined (#454) Return error in case no network service is defined Signed-off-by: Andrey Sobolev <haiodo@gmail.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Sep 9, 2020
…k@master networkservicemesh/sdk#454 networkservicemesh/sdk PR link: networkservicemesh/sdk#454 networkservicemesh/sdk commit message: commit c5c4ed12d18a9d35b624ef65f1aeec76072310b5 Author: Andrey Sobolev <haiodo@users.noreply.github.com> Date: Wed Sep 9 15:56:30 2020 +0700 Return error in case no network service is defined (#454) Return error in case no network service is defined Signed-off-by: Andrey Sobolev <haiodo@gmail.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Sep 9, 2020
…k@master networkservicemesh/sdk#454 networkservicemesh/sdk PR link: networkservicemesh/sdk#454 networkservicemesh/sdk commit message: commit c5c4ed12d18a9d35b624ef65f1aeec76072310b5 Author: Andrey Sobolev <haiodo@users.noreply.github.com> Date: Wed Sep 9 15:56:30 2020 +0700 Return error in case no network service is defined (#454) Return error in case no network service is defined Signed-off-by: Andrey Sobolev <haiodo@gmail.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-vppagent
that referenced
this pull request
Sep 9, 2020
…k@master networkservicemesh/sdk#454 networkservicemesh/sdk PR link: networkservicemesh/sdk#454 networkservicemesh/sdk commit message: commit c5c4ed12d18a9d35b624ef65f1aeec76072310b5 Author: Andrey Sobolev <haiodo@users.noreply.github.com> Date: Wed Sep 9 15:56:30 2020 +0700 Return error in case no network service is defined (#454) Return error in case no network service is defined Signed-off-by: Andrey Sobolev <haiodo@gmail.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return error in case no network service is defined
Signed-off-by: Andrey Sobolev haiodo@gmail.com