-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: connectClient freezes on request to dead server #681
Merged
haiodo
merged 2 commits into
networkservicemesh:master
from
denis-tingaikin:fix-freeze-connect-to-nse
Jan 28, 2021
Merged
fix: connectClient freezes on request to dead server #681
haiodo
merged 2 commits into
networkservicemesh:master
from
denis-tingaikin:fix-freeze-connect-to-nse
Jan 28, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denis-tingaikin
force-pushed
the
fix-freeze-connect-to-nse
branch
2 times, most recently
from
January 28, 2021 08:06
71e6cdb
to
7a82ce3
Compare
Bolodya1997
reviewed
Jan 28, 2021
denis-tingaikin
force-pushed
the
fix-freeze-connect-to-nse
branch
from
January 28, 2021 08:18
7a82ce3
to
87172b2
Compare
denis-tingaikin
requested review from
Bolodya1997,
edwarnicke,
haiodo and
artem-belov
January 28, 2021 08:21
artem-belov
reviewed
Jan 28, 2021
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
denis-tingaikin
force-pushed
the
fix-freeze-connect-to-nse
branch
from
January 28, 2021 08:36
2dca8f9
to
ea77d44
Compare
Bolodya1997
approved these changes
Jan 28, 2021
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
haiodo
approved these changes
Jan 28, 2021
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Jan 28, 2021
…k@master networkservicemesh/sdk#681 networkservicemesh/sdk PR link: networkservicemesh/sdk#681 networkservicemesh/sdk commit message: commit 1759d4b9155be7921850f6d8fbe42c8e407aba77 Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Thu Jan 28 22:00:12 2021 +0700 fix: connectClient freezes on request to dead server (#681) * fix: connectClient freezes on request to dead server Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * make tests more strict Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Jan 28, 2021
…k@master networkservicemesh/sdk#681 networkservicemesh/sdk PR link: networkservicemesh/sdk#681 networkservicemesh/sdk commit message: commit 1759d4b9155be7921850f6d8fbe42c8e407aba77 Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Thu Jan 28 22:00:12 2021 +0700 fix: connectClient freezes on request to dead server (#681) * fix: connectClient freezes on request to dead server Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * make tests more strict Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-vpp
that referenced
this pull request
Jan 28, 2021
…k@master networkservicemesh/sdk#681 networkservicemesh/sdk PR link: networkservicemesh/sdk#681 networkservicemesh/sdk commit message: commit 1759d4b9155be7921850f6d8fbe42c8e407aba77 Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Thu Jan 28 22:00:12 2021 +0700 fix: connectClient freezes on request to dead server (#681) * fix: connectClient freezes on request to dead server Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * make tests more strict Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-icmp-responder
that referenced
this pull request
Jan 28, 2021
…k@master networkservicemesh/sdk#681 networkservicemesh/sdk PR link: networkservicemesh/sdk#681 networkservicemesh/sdk commit message: commit 1759d4b9155be7921850f6d8fbe42c8e407aba77 Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Thu Jan 28 22:00:12 2021 +0700 fix: connectClient freezes on request to dead server (#681) * fix: connectClient freezes on request to dead server Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * make tests more strict Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Jan 28, 2021
…k@master networkservicemesh/sdk#681 networkservicemesh/sdk PR link: networkservicemesh/sdk#681 networkservicemesh/sdk commit message: commit 1759d4b9155be7921850f6d8fbe42c8e407aba77 Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Thu Jan 28 22:00:12 2021 +0700 fix: connectClient freezes on request to dead server (#681) * fix: connectClient freezes on request to dead server Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * make tests more strict Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Jan 28, 2021
…k@master networkservicemesh/sdk#681 networkservicemesh/sdk PR link: networkservicemesh/sdk#681 networkservicemesh/sdk commit message: commit 1759d4b9155be7921850f6d8fbe42c8e407aba77 Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Thu Jan 28 22:00:12 2021 +0700 fix: connectClient freezes on request to dead server (#681) * fix: connectClient freezes on request to dead server Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * make tests more strict Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Jan 28, 2021
…k@master networkservicemesh/sdk#681 networkservicemesh/sdk PR link: networkservicemesh/sdk#681 networkservicemesh/sdk commit message: commit 1759d4b9155be7921850f6d8fbe42c8e407aba77 Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Thu Jan 28 22:00:12 2021 +0700 fix: connectClient freezes on request to dead server (#681) * fix: connectClient freezes on request to dead server Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * make tests more strict Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Jan 28, 2021
…k@master networkservicemesh/sdk#681 networkservicemesh/sdk PR link: networkservicemesh/sdk#681 networkservicemesh/sdk commit message: commit 1759d4b9155be7921850f6d8fbe42c8e407aba77 Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Thu Jan 28 22:00:12 2021 +0700 fix: connectClient freezes on request to dead server (#681) * fix: connectClient freezes on request to dead server Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * make tests more strict Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Jan 28, 2021
…k@master networkservicemesh/sdk#681 networkservicemesh/sdk PR link: networkservicemesh/sdk#681 networkservicemesh/sdk commit message: commit 1759d4b9155be7921850f6d8fbe42c8e407aba77 Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Thu Jan 28 22:00:12 2021 +0700 fix: connectClient freezes on request to dead server (#681) * fix: connectClient freezes on request to dead server Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * make tests more strict Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Jan 28, 2021
This was referenced Jan 28, 2021
denis-tingaikin
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Jan 28, 2021
…k@master networkservicemesh/sdk#681 (#166) networkservicemesh/sdk PR link: networkservicemesh/sdk#681 networkservicemesh/sdk commit message: commit 1759d4b9155be7921850f6d8fbe42c8e407aba77 Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Thu Jan 28 22:00:12 2021 +0700 fix: connectClient freezes on request to dead server (#681) * fix: connectClient freezes on request to dead server Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * make tests more strict Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Jan 28, 2021
…cmd-nsmgr@master networkservicemesh/cmd-nsmgr# networkservicemesh/cmd-nsmgr PR link: https://github.com/networkservicemesh/cmd-nsmgr/pull/ networkservicemesh/cmd-nsmgr commit message: commit 07deee0f192c9b546c5baf1f2a585191896c9103 Author: Network Service Mesh Bot <60070799+nsmbot@users.noreply.github.com> Date: Thu Jan 28 09:20:59 2021 -0600 Update go.mod and go.sum to latest version from networkservicemesh/sdk@master networkservicemesh/sdk#681 (#166) networkservicemesh/sdk PR link: networkservicemesh/sdk#681 networkservicemesh/sdk commit message: commit 1759d4b9155be7921850f6d8fbe42c8e407aba77 Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Thu Jan 28 22:00:12 2021 +0700 fix: connectClient freezes on request to dead server (#681) * fix: connectClient freezes on request to dead server Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * make tests more strict Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> Co-authored-by: NSMBot <nsmbot@networkservicmesh.io> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Denis Tingaikin denis.tingajkin@xored.com
Closes networkservicemesh/deployments-k8s#102