Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: expire NS server incorrectly handles updates from the NSE server #684

Merged
merged 3 commits into from
Feb 2, 2021
Merged

Fix: expire NS server incorrectly handles updates from the NSE server #684

merged 3 commits into from
Feb 2, 2021

Conversation

denis-tingaikin
Copy link
Member

@denis-tingaikin denis-tingaikin commented Jan 29, 2021 •
edited
Loading

Signed-off-by: Denis Tingaikin denis.tingajkin@xored.com

Motivation

  1. ns expire server should correctly handle a case when remote registry sent an update with deleted nse.
  2. ns expire server should correctly count refs of network services in case of nse updates.

Also added/improved unit tests to cover both scenarios.

@denis-tingaikin denis-tingaikin marked this pull request as draft January 29, 2021 10:31
@denis-tingaikin denis-tingaikin force-pushed the fix-ns-expire-reg-serv branch 3 times, most recently from ae93b48 to aa740b3 Compare January 29, 2021 12:59
@denis-tingaikin denis-tingaikin marked this pull request as ready for review January 29, 2021 13:07
@denis-tingaikin
1. ns expire server should correctly handle a case when remote regist…
143bc47 
…ry sent an update with deleted nse.

2. ns expire server should correctly count refs of network services in case of nse updates.

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
@denis-tingaikin denis-tingaikin force-pushed the fix-ns-expire-reg-serv branch 2 times, most recently from 9728618 to a605ae7 Compare February 1, 2021 07:29
@denis-tingaikin
apply review comments
814547e 
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
@denis-tingaikin
apply review comments
696f2e1 
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
@haiodo haiodo merged commit 9644842 into networkservicemesh:master Feb 2, 2021
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Feb 2, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
8028d36 
…k@master networkservicemesh/sdk#684

networkservicemesh/sdk PR link: networkservicemesh/sdk#684

networkservicemesh/sdk commit message:
commit 9644842368e63e1f6f4aaa7fad49d6e027a6be46
Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com>
Date:   Tue Feb 2 23:33:23 2021 +0700

    Fix: expire NS server incorrectly handles updates from the NSE server (#684)

    * 1. ns expire server should correctly handle a case when remote registry sent an update with deleted nse.
    2. ns expire server should correctly count refs of network services in case of nse updates.

    Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

    * apply review comments

    Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

    * apply review comments

    Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Feb 2, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
8883ed9 
…k@master networkservicemesh/sdk#684

networkservicemesh/sdk PR link: networkservicemesh/sdk#684

networkservicemesh/sdk commit message:
commit 9644842368e63e1f6f4aaa7fad49d6e027a6be46
Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com>
Date:   Tue Feb 2 23:33:23 2021 +0700

    Fix: expire NS server incorrectly handles updates from the NSE server (#684)

    * 1. ns expire server should correctly handle a case when remote registry sent an update with deleted nse.
    2. ns expire server should correctly count refs of network services in case of nse updates.

    Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

    * apply review comments

    Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

    * apply review comments

    Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Feb 2, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
34015d3 
…k@master networkservicemesh/sdk#684

networkservicemesh/sdk PR link: networkservicemesh/sdk#684

networkservicemesh/sdk commit message:
commit 9644842368e63e1f6f4aaa7fad49d6e027a6be46
Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com>
Date:   Tue Feb 2 23:33:23 2021 +0700

    Fix: expire NS server incorrectly handles updates from the NSE server (#684)

    * 1. ns expire server should correctly handle a case when remote registry sent an update with deleted nse.
    2. ns expire server should correctly count refs of network services in case of nse updates.

    Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

    * apply review comments

    Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

    * apply review comments

    Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-icmp-responder that referenced this pull request Feb 2, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
b491d08 
…k@master networkservicemesh/sdk#684

networkservicemesh/sdk PR link: networkservicemesh/sdk#684

networkservicemesh/sdk commit message:
commit 9644842368e63e1f6f4aaa7fad49d6e027a6be46
Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com>
Date:   Tue Feb 2 23:33:23 2021 +0700

    Fix: expire NS server incorrectly handles updates from the NSE server (#684)

    * 1. ns expire server should correctly handle a case when remote registry sent an update with deleted nse.
    2. ns expire server should correctly count refs of network services in case of nse updates.

    Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

    * apply review comments

    Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

    * apply review comments

    Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Feb 2, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
d20e986 
…k@master networkservicemesh/sdk#684

networkservicemesh/sdk PR link: networkservicemesh/sdk#684

networkservicemesh/sdk commit message:
commit 9644842368e63e1f6f4aaa7fad49d6e027a6be46
Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com>
Date:   Tue Feb 2 23:33:23 2021 +0700

    Fix: expire NS server incorrectly handles updates from the NSE server (#684)

    * 1. ns expire server should correctly handle a case when remote registry sent an update with deleted nse.
    2. ns expire server should correctly count refs of network services in case of nse updates.

    Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

    * apply review comments

    Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

    * apply review comments

    Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Feb 2, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
2fcdd10 
…k@master networkservicemesh/sdk#684

networkservicemesh/sdk PR link: networkservicemesh/sdk#684

networkservicemesh/sdk commit message:
commit 9644842368e63e1f6f4aaa7fad49d6e027a6be46
Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com>
Date:   Tue Feb 2 23:33:23 2021 +0700

    Fix: expire NS server incorrectly handles updates from the NSE server (#684)

    * 1. ns expire server should correctly handle a case when remote registry sent an update with deleted nse.
    2. ns expire server should correctly count refs of network services in case of nse updates.

    Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

    * apply review comments

    Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

    * apply review comments

    Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Feb 2, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
1dd1132 
…k@master networkservicemesh/sdk#684

networkservicemesh/sdk PR link: networkservicemesh/sdk#684

networkservicemesh/sdk commit message:
commit 9644842368e63e1f6f4aaa7fad49d6e027a6be46
Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com>
Date:   Tue Feb 2 23:33:23 2021 +0700

    Fix: expire NS server incorrectly handles updates from the NSE server (#684)

    * 1. ns expire server should correctly handle a case when remote registry sent an update with deleted nse.
    2. ns expire server should correctly count refs of network services in case of nse updates.

    Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

    * apply review comments

    Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

    * apply review comments

    Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Feb 2, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
57a5244 
…k@master networkservicemesh/sdk#684

networkservicemesh/sdk PR link: networkservicemesh/sdk#684

networkservicemesh/sdk commit message:
commit 9644842368e63e1f6f4aaa7fad49d6e027a6be46
Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com>
Date:   Tue Feb 2 23:33:23 2021 +0700

    Fix: expire NS server incorrectly handles updates from the NSE server (#684)

    * 1. ns expire server should correctly handle a case when remote registry sent an update with deleted nse.
    2. ns expire server should correctly count refs of network services in case of nse updates.

    Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

    * apply review comments

    Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

    * apply review comments

    Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-vpp that referenced this pull request Feb 2, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
b9506da 
…k@master networkservicemesh/sdk#684

networkservicemesh/sdk PR link: networkservicemesh/sdk#684

networkservicemesh/sdk commit message:
commit 9644842368e63e1f6f4aaa7fad49d6e027a6be46
Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com>
Date:   Tue Feb 2 23:33:23 2021 +0700

    Fix: expire NS server incorrectly handles updates from the NSE server (#684)

    * 1. ns expire server should correctly handle a case when remote registry sent an update with deleted nse.
    2. ns expire server should correctly count refs of network services in case of nse updates.

    Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

    * apply review comments

    Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

    * apply review comments

    Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Feb 2, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bolodya1997 Bolodya1997 Bolodya1997 approved these changes

@haiodo haiodo haiodo approved these changes

@artem-belov artem-belov Awaiting requested review from artem-belov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@denis-tingaikin @haiodo @Bolodya1997