Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added mode L3_SUB_VLAN as tagged #311

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

barriejc
Copy link

@barriejc barriejc commented Jul 5, 2023

Working with Jeremy White at the NANOG88 hackathon June 11, 2023, we identified a few issues with adapters/nautobot_api/models.py in the network-importer instance I had installed a few months before on February 9. The Vlan tag creation issue was solved with slugify(self.name) but it seems to have been fixed in develop on Feb. 2 with this:

tag = self.diffsync.nautobot.extras.tags.create(
                name=f"device={self.name}", slug=f"device__{''.join(c if c.isalnum() else '_' for c in self.name)}"
            )

As a result, I'm only including the L3_SUB_VLAN tagged mode fix.

Copy link
Contributor

@chadell chadell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants