Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default color for device_role #38

Merged
merged 1 commit into from
May 22, 2020
Merged

Add default color for device_role #38

merged 1 commit into from
May 22, 2020

Conversation

dgarros
Copy link
Contributor

@dgarros dgarros commented May 22, 2020

Fixes #35

Also update README with missing default parameters

@dgarros dgarros requested a review from glennmatthews May 22, 2020 19:30
Copy link
Contributor

@glennmatthews glennmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@dgarros dgarros merged commit d836f42 into master May 22, 2020
@dgarros dgarros deleted the dga-issue-35 branch July 29, 2020 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants