Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Onboarding process refactor #68

Merged
merged 9 commits into from
Sep 14, 2020
Merged

Onboarding process refactor #68

merged 9 commits into from
Sep 14, 2020

Conversation

mzbroch
Copy link
Contributor

@mzbroch mzbroch commented Jul 24, 2020 •
edited
Loading

This branch refactors the onboarding process.

Changes included:

  • disaggregation of netdev objects - NetBox Keeper class no longer requires NetDev or Onboarding Task as an input
  • onboarding manager class to manage onboarding process (invokes onboarding class)
  • onboarding task manager to manage onboarding tasks information
  • new method to ensure device platform
  • idempotent behaviour to update/create onboarded devices
  • onboarding_extensions: dynamically load customized code to return onboarding class with a customized onboarding process
  • onboarding classes: support for custom onboarding classes with a fallback to a default class StandaloneOnboarding
  • added example of custom onboarding class with auto-recognition of network device role

@mzbroch mzbroch mentioned this pull request Jul 28, 2020
Merged
@dgarros dgarros changed the base branch from develop to develop-2.0 July 28, 2020 11:47
@dgarros
Copy link
Contributor

dgarros commented Jul 28, 2020

I changed the target branch to develop-2.0

@dgarros dgarros closed this Jul 28, 2020
@dgarros dgarros reopened this Jul 28, 2020
glennmatthews
glennmatthews reviewed Jul 28, 2020
View reviewed changes
Copy link
Contributor

@glennmatthews glennmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm honestly not clear on how the various classes interact here - it was complex before, and now it seems it's become even more complex. Would you mind adding to the README (or as a separate DEVELOPMENT.md?) an explanation or diagram of the flow from class to class to class?

netbox_onboarding/netbox_keeper.py Outdated Show resolved Hide resolved
netbox_onboarding/netbox_keeper.py Outdated Show resolved Hide resolved
netbox_onboarding/netbox_keeper.py Outdated Show resolved Hide resolved
netbox_onboarding/netdev_keeper.py Show resolved Hide resolved
netbox_onboarding/tests/test_netbox_keeper.py Outdated Show resolved Hide resolved
netbox_onboarding/worker.py Show resolved Hide resolved
netbox_onboarding/worker.py Outdated Show resolved Hide resolved
netbox_onboarding/netbox_keeper.py Show resolved Hide resolved
netbox_onboarding/netbox_keeper.py Outdated Show resolved Hide resolved
netbox_onboarding/netdev_keeper.py Show resolved Hide resolved
@mzbroch mzbroch mentioned this pull request Aug 2, 2020
Closed
@mzbroch mzbroch force-pushed the mzb-netbox-keeper-disaggregation branch 2 times, most recently from ca123ca to ef0792f Compare August 3, 2020 15:06
glennmatthews
glennmatthews reviewed Aug 4, 2020
View reviewed changes
netbox_onboarding/netbox_keeper.py Outdated Show resolved Hide resolved
netbox_onboarding/worker.py Outdated Show resolved Hide resolved
netbox_onboarding/netdev_keeper.py Outdated Show resolved Hide resolved
netbox_onboarding/onboarding_extensions/example_ios_set_device_role.py Outdated Show resolved Hide resolved
@mzbroch mzbroch force-pushed the mzb-netbox-keeper-disaggregation branch 6 times, most recently from 64c658e to 1d008d5 Compare August 5, 2020 12:58
glennmatthews
glennmatthews reviewed Aug 5, 2020
View reviewed changes
netbox_onboarding/onboarding/onboarding.py Show resolved Hide resolved
netbox_onboarding/onboarding_extensions/ios.py Outdated Show resolved Hide resolved
netbox_onboarding/netdev_keeper.py Show resolved Hide resolved
netbox_onboarding/onboard.py Show resolved Hide resolved
netbox_onboarding/worker.py Show resolved Hide resolved
netbox_onboarding/worker.py Outdated Show resolved Hide resolved
@mzbroch mzbroch force-pushed the mzb-netbox-keeper-disaggregation branch 6 times, most recently from 2ab05fe to 48b1623 Compare August 9, 2020 08:54
glennmatthews
glennmatthews reviewed Aug 10, 2020
View reviewed changes
.pylintrc Outdated Show resolved Hide resolved
@mzbroch mzbroch force-pushed the mzb-netbox-keeper-disaggregation branch 2 times, most recently from ac2dfa8 to 6368b21 Compare August 18, 2020 09:29
@mzbroch mzbroch force-pushed the mzb-netbox-keeper-disaggregation branch 5 times, most recently from 8685ba2 to 5402f3a Compare August 19, 2020 09:16
@mzbroch mzbroch force-pushed the mzb-netbox-keeper-disaggregation branch from 5402f3a to 813ff83 Compare August 20, 2020 11:26
@mzbroch mzbroch mentioned this pull request Aug 21, 2020
Merged
dgarros
dgarros approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@dgarros dgarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work @mzbroch

@dgarros dgarros merged commit f89e9dc into develop-2.0 Sep 14, 2020
@mzbroch mzbroch deleted the mzb-netbox-keeper-disaggregation branch November 19, 2020 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennmatthews glennmatthews glennmatthews left review comments

@dgarros dgarros dgarros approved these changes

@itdependsnetworks itdependsnetworks Awaiting requested review from itdependsnetworks

@jvanderaa jvanderaa Awaiting requested review from jvanderaa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mzbroch @dgarros @glennmatthews