-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extreme value names fix #1557
Merged
Merged
Extreme value names fix #1557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Josh VanDeraa <josh@josh-v.com>
Co-authored-by: Josh VanDeraa <josh@josh-v.com>
Co-authored-by: Josh VanDeraa <josh@josh-v.com>
…textfsm Co-authored-by: Josh VanDeraa <josh@josh-v.com>
PavloSkliarenko
requested review from
itdependsnetworks,
jmcgill298 and
jvanderaa
as code owners
November 6, 2023 15:00
jvanderaa
approved these changes
Nov 6, 2023
This was referenced Nov 6, 2023
mjbear
pushed a commit
to mjbear/ntc-templates
that referenced
this pull request
Jan 7, 2024
* Add new platform 'extreme' + 6 templates (without tests) * Fix template for 'show ipconfig' and add tests * Fix template for 'show ports description' and add tests * Fix template for 'show ports information' and add tests * rebase show ports description * Fix template for 'show sharing' and add tests * Fix template for 'show vlan description' and add tests * Fix template for 'show ports information detail' and add tests * Update ntc_templates/templates/extreme_show_ports_description.textfsm Co-authored-by: Josh VanDeraa <josh@josh-v.com> * Update ntc_templates/templates/extreme_show_ports_information.textfsm Co-authored-by: Josh VanDeraa <josh@josh-v.com> * Update ntc_templates/templates/extreme_show_vlan_description.textfsm Co-authored-by: Josh VanDeraa <josh@josh-v.com> * Update ntc_templates/templates/extreme_show_ports_information_detail.textfsm Co-authored-by: Josh VanDeraa <josh@josh-v.com> * Fix value names --------- Co-authored-by: pskliarenko <“pskliarenko@bsh.ru”> Co-authored-by: Maxim Shpak <mshpak@bsh.ru> Co-authored-by: Josh VanDeraa <josh@josh-v.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous PR I've change only value names. In this one I've fixed also templates and tests