Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding "get route" template for IPv4 for Juniper NetScreen (screenos) #180

Merged
merged 14 commits into from
Jun 25, 2018
Merged

Adding "get route" template for IPv4 for Juniper NetScreen (screenos) #180

merged 14 commits into from
Jun 25, 2018

Conversation

pbe9216
Copy link
Contributor

@pbe9216 pbe9216 commented Feb 21, 2018

ISSUE TYPE
  • New Template Pull Request
COMPONENT

juniper_screenos_get_route.template, juniper_screenos, get route

SUMMARY

Adding "get route" template for IPv4 for Juniper NetScreen firewalls (screenos)

@pbe9216
Add files via upload
70897e4 
Simple "get route" template for ScreenOS (Juniper NetScreen)
@pbe9216
Add files via upload
300dbce 
Adding screenos OS.
@pbe9216
Update index
4666a83 
Added line for juniper screenos
@pbe9216
Update juniper_screenos_get_route.template
7bdf5a4
@pbe9216
Update juniper_screenos_get_route.template
77cb6bd
@pbe9216
Update juniper_screenos_get_route.parsed
72edf3d 
Updated full parsed output
@jmcgill298
Copy link
Contributor

@burningnode This looks good overall, but need to fix a couple of things. The . in IP address matching needs to add the \ escape character. Also, all new templates need to match all strings and then have a catchall as a last match to ensure we are aware of all data from the command output. ^.+ -> Error

@pbe9216
Update juniper_screenos_get_route.template
01c8c75 
Added a few catching rules for garbage entries and the required catch all at the end.
@pbe9216
Copy link
Contributor Author

pbe9216 commented Jun 8, 2018

@jmcgill298 Thank you. Is it good right now?

@jmcgill298
Copy link
Contributor

@burningnode I have submitted a PR to you for some preferred updates. pbe9216#1

@pbe9216
Copy link
Contributor Author

pbe9216 commented Jun 25, 2018

@jmcgill298 Thanks for the improvements.

@jmcgill298 jmcgill298 merged commit 1150e13 into networktocode:master Jun 25, 2018
jvanderaa pushed a commit that referenced this pull request Nov 10, 2021
@jmcgill298
Merge pull request #180 from burningnode/master
17d9c50 
Adding "get route" template for IPv4 for Juniper NetScreen (screenos)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pbe9216 @jmcgill298