-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added description in cisco_ios_show_ip_bgp_vpnv4_all_neighbors #1906
Conversation
Added Description
I have some suggestions I'll put forth, but that won't be until this evening. |
@0lesen With that raw output, use the helper scripts to parse that raw output and add that into your PR too. https://github.com/networktocode/ntc-templates/blob/master/docs/dev/dev_environment.md Ask if you have questions. Thank you. I'd be glad to re-review once there's test data. 😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* In some output Local AS is not present so make it optional
@0lesen Thank you! |
Template changes and test data for pr1906
Thank you @0lesen! 🇩🇰 If you have access to any different vpnv4 output please test against it and even include a sanitized example. For example, I found that in the output I generated there was not a Local AS. Let's make this template's test data fully cover any differences in the CLI output! 😀 |
Added Description