Arista/show module #194
Arista/show module #194
Conversation
| Value TYPE (\S+) | ||
| Value MODEL (\S+) | ||
| Value SERIAL_NUM (\S+) | ||
| Value Fillup MAC_ADD (\S+\s+-\s+\S+) |
There was a problem hiding this comment.
Can we make this two different entries? It seems to me like sub-optimal data model'ing, e.g. trying to express two things in one field.
There was a problem hiding this comment.
@itdependsnetworks , It is a range of mac-address for a card and should be single entry as per me
There was a problem hiding this comment.
Let me enlist others, @jmcgill298 and @jedelman8 any thoughts? to me a single data field should represent a single piece of information.
There was a problem hiding this comment.
I would rather see MAC_START and MAC_END. It is easier to recompile data that is parsed with more granularity than to parse data that contains multiple pieces of information.
| Start | ||
| ^Module\s+Ports.+ | ||
| ^-.+ | ||
| ^${MODULE}\s+${PORTS}\s+${CARD}\s+${TYPE}\s+${MODEL}\s+${SERIAL_NUM} -> Record |
There was a problem hiding this comment.
I think I would rather see something like:"
Value CARD (.+)
^${MODULE}\s+${PORTS}\s+${CARD}\s+${TYPE}\s+${MODEL}\s+${SERIAL_NUM}$$ -> Record
Ensuring that there is port in there, is not likely to work for other modules.
ISSUE TYPE
COMPONENT
adding arista_eos_show_module.template
SUMMARY
adding arista_eos_show_module.template