Add support for cisco show ip mroute #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhoriguchi
changed the title
jmcgill298
reviewed
Jun 29, 2018
| Value Filldown RENDEZVOUS_POINT (\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}) | ||
| Value Filldown FLAGS (\w*) | ||
| Value Filldown INCOMING_INTERFACE (\S+) | ||
| Value Filldown INCOMING_INTERFACE_RENDEZVOUS_POINT_NEIGHBOUR_IP (\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}) |
There was a problem hiding this comment.
Why include INCOMING_INTERFACE_?
There was a problem hiding this comment.
Shouldn't this be reverse path forwarding neighbor?
| Value Filldown FLAGS (\w*) | ||
| Value Filldown INCOMING_INTERFACE (\S+) | ||
| Value Filldown INCOMING_INTERFACE_RENDEZVOUS_POINT_NEIGHBOUR_IP (\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}) | ||
| Value Filldown INCOMING_INTERFACE_REGISTERING (Registering) |
There was a problem hiding this comment.
Why include INCOMING_INTERFACE_?
| Value Filldown INCOMING_INTERFACE_RENDEZVOUS_POINT_NEIGHBOUR_IP (\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}) | ||
| Value Filldown INCOMING_INTERFACE_REGISTERING (Registering) | ||
| Value OUTGOING_INTERFACE (\S+) | ||
| Value OUTGOING_INTERFACE_FORWARD_MODE (Forward\/Sparse|Forward\/Dense) |
There was a problem hiding this comment.
Why include OUTGOING_INTERFACE_?
Update mroute to capture all known lines and raise an error if a line is not matched by the parser
jmcgill298
pushed a commit
to jmcgill298/ntc-templates
that referenced
this pull request
Oct 14, 2018
* Add support for cisco show ip mroute * Rename field * Use list for fields that can repeat several times * Update .gitignore * Update empty mroute to be empty list * Update template to raise an error for unmatched lines
jvanderaa
pushed a commit
that referenced
this pull request
Nov 10, 2021
* Add support for cisco show ip mroute * Rename field * Use list for fields that can repeat several times * Update .gitignore * Update empty mroute to be empty list * Update template to raise an error for unmatched lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
COMPONENT
Template name: cisco_ios_show_ip_mroute
Os: Cisco IOS
Command: show ip mroute
SUMMARY
Adding "show ip mroute" template for Cisco IOS IP multicast routing table