Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add juniper_junos_show_chassis_cluster_interfaces #296

Conversation

jkraszewski
Copy link
Contributor

ISSUE TYPE
  • New Template Pull Request
COMPONENT

juniper_junos_show_chassis_cluster_interfaces.template, junos, show chassis cluster interfaces

SUMMARY

New juniper template

Copy link
Contributor

@jmcgill298 jmcgill298 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of these are commented out and the template is missing a catch-all expression that raises an Error

@jkraszewski
Copy link
Contributor Author

@jmcgill298 to my knowledge I only needed 2 pieces of information from this commands result so I was only grabbing those values. I could remove all of the comments and leave the lines that grab those values but the error line would break it. How should I proceed?

@jmcgill298
Copy link
Contributor

We have to match all of the lines regardless of whether we capture all of the possible data. This is the only way we can ensure we know all of the data was captured correctly.

@jmcgill298 jmcgill298 merged commit c88ed51 into networktocode:master Dec 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants