Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cisco_ios_show_dot1x_all command #308

Merged
merged 5 commits into from
Dec 31, 2018
Merged

cisco_ios_show_dot1x_all command #308

merged 5 commits into from
Dec 31, 2018

Conversation

realvitya
Copy link
Contributor

ISSUE TYPE
  • New Template Pull Request
COMPONENT

cisco_ios_show_dot1x_all.template, Cisco IOS, show dot1x all

SUMMARY

This template was missing and I needed one for my scripts which had to read which ports are configured for dot1x. This command and therefore the template is working on variety of Cisco switch platforms.
Tested on 3k, 4k and 6k series.

Copy link
Contributor

@jmcgill298 jmcgill298 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The index file should be updated according to the following rules:

# Rules of Ordering:
#  - OS in alphbetical order
#  - Command in length other
#  - When Length is the same, use alphabetical order
#  - Keep space between OS's

Also, all new templates require providing a match for each line and at the end of each state having a catch all that raises an error. This is the only way we can know that we are accurately reporting all of the data.

  ^\s*$$
  ^. -> Errorr

templates/cisco_ios_show_dot1x_all.template Outdated Show resolved Hide resolved
jmcgill298 and others added 2 commits December 5, 2018 12:53
fix to error out on unknown input and ensure read only what we expect

Co-Authored-By: realvitya <vkertesz2@gmail.com>
@realvitya
Copy link
Contributor Author

Thanks Jacob! I updated the code to fix your comments.

@realvitya realvitya closed this Dec 8, 2018
@realvitya realvitya reopened this Dec 8, 2018
@jmcgill298 jmcgill298 merged commit 0540983 into networktocode:master Dec 31, 2018
@jmcgill298
Copy link
Contributor

Thanks @realvitya

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants