IOS DIR: Account for spaces in permissions #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* New data was found that had spaces in permissions data. * Update template to allow for this space using `(.+?)`. * Remove state change as it does not seem to be doing much. * Simplify `date_time` to use `(.+?)` and add end of line, `\s*$$` to capture whatever text shows up between `SIZE` and `NAME`. * Remove unnecesarry capture groups that were not assigned to named capture groups.
jvanderaa
pushed a commit
that referenced
this pull request
Nov 10, 2021
* New data was found that had spaces in permissions data. * Update template to allow for this space using `(.+?)`. * Remove state change as it does not seem to be doing much. * Simplify `date_time` to use `(.+?)` and add end of line, `\s*$$` to capture whatever text shows up between `SIZE` and `NAME`. * Remove unnecesarry capture groups that were not assigned to named capture groups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New data was found that had spaces in permissions data.
Update template to allow for this space using
(.+?).Remove state change as it does not seem to be doing much.
Simplify
date_timeto use(.+?)and add end of line,\s*$$tocapture whatever text shows up between
SIZEandNAME.Remove unnecesarry capture groups that were not assigned to named
capture groups.
ISSUE TYPE
COMPONENT
SUMMARY