Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/improve cisco ios show vrf #395

Conversation

MatthiasGabriel
Copy link
Contributor

@MatthiasGabriel MatthiasGabriel commented Apr 16, 2019

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT

Template: cisco_ios_show_vrf
OS: Cisco IOS
Command: show vrf

SUMMARY

Allow the default_rd to contain an ip-address. The current template only allows to use an AS number.
Quote of cisco: Creates a VRF table by specifying a route distinguisher. Enter either an AS number and an arbitrary number (xxx:y) or an IP address and arbitrary number (A.B.C.D:y).

Quote of cisco: Creates a VRF table by specifying a route distinguisher. Enter either an AS number and an arbitrary number (xxx:y) or an IP address and arbitrary number (A.B.C.D:y).
@@ -167,3 +167,6 @@
Vl940
Vl941
Vl946
vpn7 127.0.0.1:7 ipv4 Vl5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please upload a separate .raw and .parsed? This helps ensure backwards capability and adds more data to test the template against.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I extracted the raw and parsed files into new one. Hope it's what you expected ;)

@FragmentedPacket FragmentedPacket added the changes_requested Waiting on user to address feedback label Jul 27, 2019
MatthiasGabriel and others added 2 commits July 31, 2019 08:51
Add empty line to match the file before any modifications were made
@FragmentedPacket FragmentedPacket merged commit ff765de into networktocode:master Aug 2, 2019
jvanderaa pushed a commit that referenced this pull request Nov 10, 2021
BugFix: Allow RD to be IP address
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes_requested Waiting on user to address feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants