Issue #384 cisco_asa_show_route - Fix uptime issue #401

brandomando · 2019-04-20T04:04:09Z

ISSUE TYPE

Bugfix Pull Request

COMPONENT

cisco_asa_show_route

SUMMARY

Uptime populating into nexthopif value because the uptime value was not placed into the template correctly.

Fixes #384

Before:

[{'protocol': 'S',
  'type': '',
  'network': 'Server1',
  'mask': '255.255.255.255',
  'distance': '1',
  'metric': '0',
  'nexthopip': '10.0.5.12',
  'nexthopif': 'outside',
  'uptime': ''},
 {'protocol': 'S',
  'type': '',
  'network': '10.64.65.82',
  'mask': '255.255.255.255',
  'distance': '1',
  'metric': '0',
  'nexthopip': '10.100.67.246',
  'nexthopif': 'outside',
  'uptime': ''},
 {'protocol': 'S',
  'type': '',
  'network': 'Sever-2',
  'mask': '255.255.255.255',
  'distance': '1',
  'metric': '0',
  'nexthopip': '10.0.5.12',
  'nexthopif': 'outside',
  'uptime': ''},
 {'protocol': 'S',
  'type': '',
  'network': '192.168.14.95',
  'mask': '255.255.255.255',
  'distance': '1',
  'metric': '0',
  'nexthopip': '10.0.5.12',
  'nexthopif': 'outside',
  'uptime': ''},
 {'protocol': 'S',
  'type': '',
  'network': 'Server_3',
  'mask': '255.255.255.255',
  'distance': '1',
  'metric': '0',
  'nexthopip': '10.0.5.12',
  'nexthopif': 'outside',
  'uptime': ''},
 {'protocol': 'S',
  'type': '',
  'network': '10.54.6.0',
  'mask': '255.255.255.0',
  'distance': '1',
  'metric': '0',
  'nexthopip': '10.0.5.12',
  'nexthopif': 'outside',
  'uptime': ''},
 {'protocol': 'S',
  'type': '',
  'network': 'SERVER',
  'mask': '255.255.255.255',
  'distance': '1',
  'metric': '0',
  'nexthopip': '10.0.5.12',
  'nexthopif': 'outside',
  'uptime': ''},
 {'protocol': 'S',
  'type': '',
  'network': '192.168.10.0',
  'mask': '255.255.255.64',
  'distance': '1',
  'metric': '0',
  'nexthopip': '172.52.64.1',
  'nexthopif': 'inside',
  'uptime': ''},
 {'protocol': 'S',
  'type': '',
  'network': 'server',
  'mask': '255.255.255.255',
  'distance': '1',
  'metric': '0',
  'nexthopip': '172.52.64.1',
  'nexthopif': 'inside',
  'uptime': ''},
 {'protocol': 'S',
  'type': '',
  'network': '10.14.128.0',
  'mask': '255.255.255.0',
  'distance': '1',
  'metric': '0',
  'nexthopip': '172.52.64.1',
  'nexthopif': 'inside',
  'uptime': ''},
 {'protocol': 'S',
  'type': '',
  'network': '10.13.0.0',
  'mask': '255.255.0.0',
  'distance': '1',
  'metric': '0',
  'nexthopip': '172.52.64.1',
  'nexthopif': 'inside',
  'uptime': ''},
 {'protocol': 'S',
  'type': '',
  'network': '10.3.18.16',
  'mask': '255.255.255.255',
  'distance': '1',
  'metric': '0',
  'nexthopip': '172.52.64.1',
  'nexthopif': 'inside',
  'uptime': ''},
 {'protocol': 'C',
  'type': '',
  'network': '192.168.1.0',
  'mask': '255.255.255.0',
  'distance': '',
  'metric': '',
  'nexthopip': '',
  'nexthopif': 'outside',
  'uptime': ''},
 {'protocol': 'L',
  'type': '',
  'network': '192.168.1.108',
  'mask': '255.255.255.255',
  'distance': '',
  'metric': '',
  'nexthopip': '',
  'nexthopif': 'outside',
  'uptime': ''},
 {'protocol': 'O',
  'type': 'IA',
  'network': '172.16.2.254',
  'mask': '255.255.255.255',
  'distance': '110',
  'metric': '11',
  'nexthopip': '192.168.2.2',
  'nexthopif': 'inside',
  'uptime': '3:21:21'},
 {'protocol': 'O',
  'type': 'IA',
  'network': '172.16.3.254',
  'mask': '255.255.255.255',
  'distance': '110',
  'metric': '11',
  'nexthopip': '192.168.2.2',
  'nexthopif': 'inside',
  'uptime': '3:21:21'},
 {'protocol': 'O',
  'type': 'IA',
  'network': '172.16.1.254',
  'mask': '255.255.255.255',
  'distance': '110',
  'metric': '11',
  'nexthopip': '192.168.2.2',
  'nexthopif': 'inside',
  'uptime': '3:21:21'},
 {'protocol': 'O',
  'type': 'IA',
  'network': '172.16.4.254',
  'mask': '255.255.255.255',
  'distance': '110',
  'metric': '11',
  'nexthopip': '192.168.2.2',
  'nexthopif': 'inside',
  'uptime': '3:21:21'},
 {'protocol': 'O',
  'type': 'IA',
  'network': '10.0.4.254',
  'mask': '255.255.255.255',
  'distance': '110',
  'metric': '11',
  'nexthopip': '192.168.1.2',
  'nexthopif': 'outside',
  'uptime': '3:21:21'},
 {'protocol': 'O',
  'type': 'IA',
  'network': '10.0.1.254',
  'mask': '255.255.255.255',
  'distance': '110',
  'metric': '11',
  'nexthopip': '192.168.1.2',
  'nexthopif': 'outside',
  'uptime': '3:21:21'},
 {'protocol': 'O',
  'type': 'IA',
  'network': '10.0.2.254',
  'mask': '255.255.255.255',
  'distance': '110',
  'metric': '11',
  'nexthopip': '192.168.1.2',
  'nexthopif': 'outside',
  'uptime': '3:21:21'},
 {'protocol': 'O',
  'type': 'IA',
  'network': '10.0.3.254',
  'mask': '255.255.255.255',
  'distance': '110',
  'metric': '11',
  'nexthopip': '192.168.1.2',
  'nexthopif': 'outside',
  'uptime': '3:21:21'},
 {'protocol': 'O',
  'type': 'E2',
  'network': '10.1.1.0',
  'mask': '255.255.255.0',
  'distance': '170',
  'metric': '3840',
  'nexthopip': '192.168.1.2',
  'nexthopif': '3:21:21',
  'uptime': ''},
 {'protocol': 'O',
  'type': 'E2',
  'network': '10.1.2.0',
  'mask': '255.255.255.0',
  'distance': '170',
  'metric': '3840',
  'nexthopip': '192.168.1.2',
  'nexthopif': '3:21:21',
  'uptime': ''},
 {'protocol': 'O',
  'type': 'E2',
  'network': '10.1.3.0',
  'mask': '255.255.255.0',
  'distance': '170',
  'metric': '3840',
  'nexthopip': '192.168.1.2',
  'nexthopif': '3:21:21',
  'uptime': ''},
 {'protocol': 'C',
  'type': '',
  'network': '192.168.1.0',
  'mask': '255.255.255.0',
  'distance': '',
  'metric': '',
  'nexthopip': '',
  'nexthopif': 'outside',
  'uptime': ''},
 {'protocol': 'C',
  'type': '',
  'network': '192.168.2.0',
  'mask': '255.255.255.0',
  'distance': '',
  'metric': '',
  'nexthopip': '',
  'nexthopif': 'inside',
  'uptime': ''}]

After:

[{'protocol': 'S',
  'type': '',
  'network': 'Server1',
  'mask': '255.255.255.255',
  'distance': '1',
  'metric': '0',
  'nexthopip': '10.0.5.12',
  'nexthopif': 'outside',
  'uptime': ''},
 {'protocol': 'S',
  'type': '',
  'network': '10.64.65.82',
  'mask': '255.255.255.255',
  'distance': '1',
  'metric': '0',
  'nexthopip': '10.100.67.246',
  'nexthopif': 'outside',
  'uptime': ''},
 {'protocol': 'S',
  'type': '',
  'network': 'Sever-2',
  'mask': '255.255.255.255',
  'distance': '1',
  'metric': '0',
  'nexthopip': '10.0.5.12',
  'nexthopif': 'outside',
  'uptime': ''},
 {'protocol': 'S',
  'type': '',
  'network': '192.168.14.95',
  'mask': '255.255.255.255',
  'distance': '1',
  'metric': '0',
  'nexthopip': '10.0.5.12',
  'nexthopif': 'outside',
  'uptime': ''},
 {'protocol': 'S',
  'type': '',
  'network': 'Server_3',
  'mask': '255.255.255.255',
  'distance': '1',
  'metric': '0',
  'nexthopip': '10.0.5.12',
  'nexthopif': 'outside',
  'uptime': ''},
 {'protocol': 'S',
  'type': '',
  'network': '10.54.6.0',
  'mask': '255.255.255.0',
  'distance': '1',
  'metric': '0',
  'nexthopip': '10.0.5.12',
  'nexthopif': 'outside',
  'uptime': ''},
 {'protocol': 'S',
  'type': '',
  'network': 'SERVER',
  'mask': '255.255.255.255',
  'distance': '1',
  'metric': '0',
  'nexthopip': '10.0.5.12',
  'nexthopif': 'outside',
  'uptime': ''},
 {'protocol': 'S',
  'type': '',
  'network': '192.168.10.0',
  'mask': '255.255.255.64',
  'distance': '1',
  'metric': '0',
  'nexthopip': '172.52.64.1',
  'nexthopif': 'inside',
  'uptime': ''},
 {'protocol': 'S',
  'type': '',
  'network': 'server',
  'mask': '255.255.255.255',
  'distance': '1',
  'metric': '0',
  'nexthopip': '172.52.64.1',
  'nexthopif': 'inside',
  'uptime': ''},
 {'protocol': 'S',
  'type': '',
  'network': '10.14.128.0',
  'mask': '255.255.255.0',
  'distance': '1',
  'metric': '0',
  'nexthopip': '172.52.64.1',
  'nexthopif': 'inside',
  'uptime': ''},
 {'protocol': 'S',
  'type': '',
  'network': '10.13.0.0',
  'mask': '255.255.0.0',
  'distance': '1',
  'metric': '0',
  'nexthopip': '172.52.64.1',
  'nexthopif': 'inside',
  'uptime': ''},
 {'protocol': 'S',
  'type': '',
  'network': '10.3.18.16',
  'mask': '255.255.255.255',
  'distance': '1',
  'metric': '0',
  'nexthopip': '172.52.64.1',
  'nexthopif': 'inside',
  'uptime': ''},
 {'protocol': 'C',
  'type': '',
  'network': '192.168.1.0',
  'mask': '255.255.255.0',
  'distance': '',
  'metric': '',
  'nexthopip': '',
  'nexthopif': 'outside',
  'uptime': ''},
 {'protocol': 'L',
  'type': '',
  'network': '192.168.1.108',
  'mask': '255.255.255.255',
  'distance': '',
  'metric': '',
  'nexthopip': '',
  'nexthopif': 'outside',
  'uptime': ''},
 {'protocol': 'O',
  'type': 'IA',
  'network': '172.16.2.254',
  'mask': '255.255.255.255',
  'distance': '110',
  'metric': '11',
  'nexthopip': '192.168.2.2',
  'nexthopif': 'inside',
  'uptime': '3:21:21'},
 {'protocol': 'O',
  'type': 'IA',
  'network': '172.16.3.254',
  'mask': '255.255.255.255',
  'distance': '110',
  'metric': '11',
  'nexthopip': '192.168.2.2',
  'nexthopif': 'inside',
  'uptime': '3:21:21'},
 {'protocol': 'O',
  'type': 'IA',
  'network': '172.16.1.254',
  'mask': '255.255.255.255',
  'distance': '110',
  'metric': '11',
  'nexthopip': '192.168.2.2',
  'nexthopif': 'inside',
  'uptime': '3:21:21'},
 {'protocol': 'O',
  'type': 'IA',
  'network': '172.16.4.254',
  'mask': '255.255.255.255',
  'distance': '110',
  'metric': '11',
  'nexthopip': '192.168.2.2',
  'nexthopif': 'inside',
  'uptime': '3:21:21'},
 {'protocol': 'O',
  'type': 'IA',
  'network': '10.0.4.254',
  'mask': '255.255.255.255',
  'distance': '110',
  'metric': '11',
  'nexthopip': '192.168.1.2',
  'nexthopif': 'outside',
  'uptime': '3:21:21'},
 {'protocol': 'O',
  'type': 'IA',
  'network': '10.0.1.254',
  'mask': '255.255.255.255',
  'distance': '110',
  'metric': '11',
  'nexthopip': '192.168.1.2',
  'nexthopif': 'outside',
  'uptime': '3:21:21'},
 {'protocol': 'O',
  'type': 'IA',
  'network': '10.0.2.254',
  'mask': '255.255.255.255',
  'distance': '110',
  'metric': '11',
  'nexthopip': '192.168.1.2',
  'nexthopif': 'outside',
  'uptime': '3:21:21'},
 {'protocol': 'O',
  'type': 'IA',
  'network': '10.0.3.254',
  'mask': '255.255.255.255',
  'distance': '110',
  'metric': '11',
  'nexthopip': '192.168.1.2',
  'nexthopif': 'outside',
  'uptime': '3:21:21'},
 {'protocol': 'O',
  'type': 'E2',
  'network': '10.1.1.0',
  'mask': '255.255.255.0',
  'distance': '170',
  'metric': '3840',
  'nexthopip': '192.168.1.2',
  'nexthopif': 'outside',
  'uptime': '3:21:21'},
 {'protocol': 'O',
  'type': 'E2',
  'network': '10.1.2.0',
  'mask': '255.255.255.0',
  'distance': '170',
  'metric': '3840',
  'nexthopip': '192.168.1.2',
  'nexthopif': 'outside',
  'uptime': '3:21:21'},
 {'protocol': 'O',
  'type': 'E2',
  'network': '10.1.3.0',
  'mask': '255.255.255.0',
  'distance': '170',
  'metric': '3840',
  'nexthopip': '192.168.1.2',
  'nexthopif': 'outside',
  'uptime': '3:21:21'},
 {'protocol': 'C',
  'type': '',
  'network': '192.168.1.0',
  'mask': '255.255.255.0',
  'distance': '',
  'metric': '',
  'nexthopip': '',
  'nexthopif': 'outside',
  'uptime': ''},
 {'protocol': 'C',
  'type': '',
  'network': '192.168.2.0',
  'mask': '255.255.255.0',
  'distance': '',
  'metric': '',
  'nexthopip': '',
  'nexthopif': 'inside',
  'uptime': ''}]

…plate

…xt hops

…_route tests

…e parsed data for tests

…d routes

brandomando · 2019-04-20T05:18:30Z

Sorry for the sloppy commits. Please feel free to squash merge if you choose to merge. Let me know if there are any comments/fixes that need to be looked at with this, but the issue was fairly straightforward. The value UPTIME was missing in several places, and there was a space prior to \s+ in the load-balanced template.

Thanks,

Brandon

brandomando · 2019-04-20T05:19:51Z

Also fixed, the uptime value only accounted for the hh:mm:ss format, but not the NwNd format. I added that to the UPTIME regex as well.

FragmentedPacket

@brandomando Do you mind uploading a separate .raw and .parsed files for the tests rather than editing the existing one? After that change and tests passing, I will get this merged in.

jmcgill298 · 2019-09-27T01:56:59Z

templates/cisco_asa_show_route.template

@@ -6,7 +6,7 @@ Value DISTANCE (\d+)
 Value METRIC (\d+)
 Value NEXTHOPIP (\d+\.\d+\.\d+\.\d+)
 Value NEXTHOPIF (\S+)
-Value UPTIME (\d+:\d+:\d+)
+Value UPTIME ((\d+:\d+:\d+)|(\d+w\d+d))


Does \S+ work for UPTIME? I'm sure this converts to \d+y\d+d after a year.

brandomando added 8 commits April 19, 2019 21:43

Issue networktocode#384 Fix uptime values in cisco_asa_show_route tem…

972cbc3

…plate

Add routes to show_route test in cisco_asa to account for multiple ne…

1eec740

…xt hops

Issue networktocode#384 added update parsed values for cisco_asa_show…

4fa1b7a

…_route tests

Issue networktocode#384 fixed yaml formatting for cisco_asa_show_rout…

c4e3669

…e parsed data for tests

Fix yaml syntax errors in cisco_asa_show_route.parsed

06efb33

Fixed spacing issue in cisco_asa_show_route template for load-balance…

aa04207

…d routes

Add week-day uptime in tests. Fix tests for load-balanced routes

ebd11ad

Fixed parsed data for test

9c822ce

FragmentedPacket added the changes_requested Waiting on user to address feedback label Jul 19, 2019

FragmentedPacket suggested changes Jul 19, 2019

View reviewed changes

jmcgill298 requested changes Sep 27, 2019

View reviewed changes

jmcgill298 added bug waiting_response labels Sep 27, 2019

jmcgill298 added 2 commits October 22, 2019 16:53

Account for additional formats of UPTIME

5c5db1c

Remove incorrect captures

c048314

jmcgill298 merged commit dccc8c7 into networktocode:master Oct 22, 2019

brandomando deleted the asa_show_route branch August 8, 2020 02:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue #384 cisco_asa_show_route - Fix uptime issue #401

Issue #384 cisco_asa_show_route - Fix uptime issue #401

brandomando commented Apr 20, 2019

brandomando commented Apr 20, 2019

brandomando commented Apr 20, 2019

FragmentedPacket left a comment

jmcgill298 Sep 27, 2019

Issue #384 cisco_asa_show_route - Fix uptime issue #401

Issue #384 cisco_asa_show_route - Fix uptime issue #401

Conversation

brandomando commented Apr 20, 2019

ISSUE TYPE

COMPONENT

SUMMARY

brandomando commented Apr 20, 2019

brandomando commented Apr 20, 2019

FragmentedPacket left a comment

Choose a reason for hiding this comment

jmcgill298 Sep 27, 2019

Choose a reason for hiding this comment