Added Pipenv and Pipenv.lock files and Changed README (Fixes #411) #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…README to tell people how to get started.
|
Thanks for the suggestion. We discussed this internally, and we would prefer to not use pipenv for this project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
SUMMARY
Added a Pipfile and Pipfile.lock so the virtual environment can be easily set up to install and run tox.
pipenv is the current Pythonic way to set up a virtual environment. I believe the requirements.txt is now depricated.
Added a couple of lines to the README.md file to tell people how to install the virtual environment and run tox. When I first cloned the package I was stumped as to how to run the tests as the README does not give any guidance on setup. Running the .py files directly just gives errors. I had to ask in slack.
Fixes Issue #411